On 2015-09-04 09:58+0100 Phil Rosenberg wrote: > Hi Alan > To be clear - Plplot built fine for me with VS 2015 even with snprintf > not being found.
Note the PL_HAVE_SNPRINTF and _PL_HAVE_SNPRINTF preprocessor logic in include/plplotP.h. So that build was using a last-resort unsafe alternative for snprintf. Therefore, it is good that my fix now does allow our build system to find and use the safe system version of snprintf for VS2015 from what you said below. I also saw your additional note on the bug tracker. I hope Thorsten's and your further experience with VS2015 turns up no further issues so we can close bug 179. > The only issue on my PC was with including other > static libraries built with previous VS versions and statically linked > to the runtime. So shapelib was built expecting to find snprintf in > the runtime library. Whether or not CMake finds the new inline version > of snprintf in the VS 2015 runtime is irrelevant. The function > definition is not in that runtime library so it can't be found to link > against the instance in shapelib. > > The solution there is to rebuild all static libraries used by plplot > using the same VS version. Alternatively I think using dlls instead or > dynamically linking to the runtime might fix the problem. > > Anyway I tested and CMake does now find snprintf, but x00.exe will not > link because my shapelib was built with VS 2012. This doesn't mean > that your change is incorrect. It just means I need to rebuild > shapelib with VS2015 too. OK, and good luck with your consistent VS2015 builds going forward. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
