On 2016-12-17 03:43-0500 Pedro Vicente wrote:

> There's a small change that must be done in my 2nd patch
>
> here
>
> bool wxPLplotwindow<WXWINDOW>::Show(bool show)
> {
> wxLogDebug("wxPLplotwindow::Show");
> CreateStream();
> WXWINDOW::Show(show);
>
> }
>
>
> it should be instead
>
> return WXWINDOW::Show(show);
>
> gcc let me get away with it, but it's an error in Visual Studio

Please go ahead and make a commit to that effect, and send it to me
for pushing.  Please include a tested by: paragraph identifying the
system where you did the test similar to how I have been massaging
your recent commit messages when I describe the tests that you did for
them.  I will amend the commit message in any case to add my own
tested by: paragraph for my own test of your commit here.

I hope you don't find that commit + "git format-patch" process too
difficult. I used that method a lot when colloborating on maturing a
major private topic branch (our new Fortran binding) with Arjen, and that
process became very easy and straightforward for us very soon in that
quite extensive collaboration process although neither of us had used
"git format-patch" (or "git am") extensively before our collaboration.

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to