Hi Nicolas,

Thanks for this information. The original patch had some Debian-specific 
environment variables, so I started to wonder about the relation to the Debian 
platform. I will have a closer look at this.

Regards,

Arjen

-----Original Message-----
From: Nicolas Boulenguez <nico...@debian.org>
Sent: 19 December 2022 11:55
To: Arjen Markus <arjen.mar...@deltares.nl>
Cc: Rafael Laboissière <raf...@laboissiere.net>; PLplot development list 
<plplot-devel@lists.sourceforge.net>
Subject: Re: [Plplot-devel] Build a static version of libplplotada

Caution: This message was sent from outside of Deltares. Please do not click 
links or open attachments unless you recognize the source of this email and 
know the content is safe. Please report all suspicious emails to 
"servicedesk-...@deltares.nl" as an attachment.


Hello.

These suggestions are not specific to Debian or Ada.

The most common kind of libraries is shared/relocatable (.so/dll/...), but some 
people may want a static library (.a/.o/...) or more exotic choices (static-pic 
for example).

Currently, plplotada builds a shared library.  This is good.

CMake seems able to also build a static library.  As far as I understand 
Rafael's commit, adding the following line into bindings/ada/CMakeLists.txt 
tells CMake to build *both* the shared and static library.

  configure_library_build(plplotada_static STATIC "${plplotada_BODY_SRCS}" "" 
"${LIB_INSTALL_RPATH}")

Debian is happy with this, but this is probably not a satisfying default.  I 
suggest to make the static library an opt-in option.

if(enable_ADA_STATIC)
  # Also build the static library
  configure_library_build(plplotada_static STATIC "${plplotada_BODY_SRCS}" "" 
"${LIB_INSTALL_RPATH}")
endif(enable_ADA_STATIC)

The ideal would be to allow any combination through an explicit configure 
option for each library kind.  I do not know how easy it would be, and this is 
not useful to Debian right now.

By the way, does this trivial change not fix the renaming issue?

  configure_library_build(plplotada STATIC "${plplotada_BODY_SRCS}" "" 
"${LIB_INSTALL_RPATH}")
DISCLAIMER: This message is intended exclusively for the addressee(s) and may 
contain confidential and privileged information. If you are not the intended 
recipient please notify the sender immediately and destroy this message. 
Unauthorized use, disclosure or copying of this message is strictly prohibited. 
The foundation 'Stichting Deltares', which has its seat at Delft, The 
Netherlands, Commercial Registration Number 41146461, is not liable in any way 
whatsoever for consequences and/or damages resulting from the improper, 
incomplete and untimely dispatch, receipt and/or content of this e-mail.


_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to