[plt-dev] bugfix for handin-server

[John Clements]

AFAICT, the handin-server is written with the assumption that (current- directory) returns a string. In particular, the 'run-servlet' function in web-status-server.ss calls string->path on server-dir, which may be obtained using (current-directory). Fortunately, it appears that the downstream uses of this value don't require it to be a string, so it appears that you can fix this problem simply by removing the call to string->path. Here's the diff:

Index: web-status-server.ss
===================================================================
--- web-status-server.ss        (revision 14438)
+++ web-status-server.ss        (working copy)
@@ -251,14 +251,13 @@



 (define ((run-servlet port))
-  (define dir (string->path server-dir))
   (serve/servlet
    (lambda (request)
      (parameterize ([current-session (web-counter)])
        (login-page (aget (request-bindings request) 'handin) #f)))
    #:port port #:listen-ip #f #:ssl? #t #:command-line? #t
    #:servlet-path "/" #:servlet-regexp #rx""
-   #:server-root-path dir #:servlets-root dir
+   #:server-root-path server-dir #:servlets-root server-dir
    #:file-not-found-responder (send-error "File not found")
    #:servlet-namespace '(handin-server/private/md5
                          handin-server/private/logger


I've committed this; naturally, I'll unwind it if I've made a mistake.

John

cleme...@li21-127:~/class/collects/handin-server$ svn diff web-status- server.ss (body ,msg "; " (a ([href "/"]) "restarting") " in 3 seconds.")))

smime.p7s
Description: S/MIME cryptographic signature

_________________________________________________
  For list-related administrative tasks:
  http://list.cs.brown.edu/mailman/listinfo/plt-dev