mherger;361332 Wrote: 
> 
> - imho you're initializing stuff which isn't needed in this plugin:
> 
> use Slim::Buttons::Home;
> use File::Spec::Functions qw(:ALL);
> use DBI qw(:sql_types);
> use FindBin qw($Bin);
> my @pluginDirs = ();
> 
> removing them would probably help save a few bytes
> 
Thanks, some leftovers from the plugin skeleton I started with, will be
removed in next release.

mherger;361332 Wrote: 
> 
> - couldn't you use
> 
> $client->pluginData($format)
> 
> instead of
> 
> $clientFormats->{$client->id}->{$format}
> 
Thanks again, this feels a lot cleaner, there are probably other places
in my plugins where I should use this.


-- 
erland

Erland Isaksson
'My homepage' (http://erland.isaksson.info) 'My download page'
(http://erland.isaksson.info/download)
(Developer of 'TrackStat, SQLPlayList, DynamicPlayList, Custom Browse,
Custom Scan,  Custom Skip, Multi Library and Database Query plugins'
(http://wiki.erland.isaksson.info/index.php/Category:SlimServer))
------------------------------------------------------------------------
erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=55240

_______________________________________________
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/lists/listinfo/plugins

Reply via email to