Sorry, I made a stupid mistake: SimplePreferenceTest.checkPreferencesValidator() just tests if validator is called and ValidationException is caught...

Just forget this mail... Next time I will be more careful when reading code.

2005/9/13, Zhong ZHENG <[EMAIL PROTECTED]>:
Hi,

In the testsuite (in Pluto 1.1), SimplePreferenceTest, I found that in the method checkPreferenceValidator() you are checking if preference attribute values are trimmed strings:

    protected TestResult checkPreferenceValidator(PortletRequest req) {
        ... ...
        try {
            preferences.setValue("VALIDATION_TEST_KEY", " Spaces removed by trim ");
            preferences.store(); // Validation failed in the store() method: value not trimmed.
        }
        catch ... ...
    }

That check failed everytime the validator is called: attribute values are not trimmed by PortletPreferencesImpl. I checked the portlet spec, PLT. 14, but I didn't find a section saying that preference attribute values should be trimmed. So, why did you write this checking method? Is that really required by the spec?

BTW, the validator class loading problem was resolved here:
http://issues.apache.org/jira/browse/PLUTO-159


Regards.

--

ZHENG Zhong

1 Avenue Alphand
75116 Paris, France
+33 6 76 80 45 90

heavyzheng {AT} gmail {D0T} com

http://heavyz.sourceforge.net
http://heavyz.blogspot.com
http://spaces.msn.com/members/zhengzhong



--

ZHENG Zhong

1 Avenue Alphand
75116 Paris, France
+33 6 76 80 45 90

heavyzheng {AT} gmail {D0T} com

http://heavyz.sourceforge.net
http://heavyz.blogspot.com
http://spaces.msn.com/members/zhengzhong


Reply via email to