Hey Craig, thanks this is great. I'm looking forward to the new admin portlet! By the looks of things, Gump should be happy.
Ah, back to the salt mines on Monday. Elliot Sent from webmail (apologies for the poor quoting) >>> "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> 08/27/06 8:07 PM >>> Hi Elliot, I've just committed the code to the 1.0.2 branch. The admin portlet now uses commons-fileupload 1.1 to do its file upload. I've also added an init-param to the portlet.xml to allow for configuration of maximum allowed upload size. Previously no uploads of war files to be deployed were allowed if they were greater than 10 megabytes. I'm also starting to work on an admin portlet for Pluto 1.1 that will be much more configurable that the current 1.0.1 admin portlet. Hopefully, gump will calm down now. /Craig Original Message: ----------------- From: Elliot Metsger [EMAIL PROTECTED] Date: Sun, 27 Aug 2006 19:46:27 -0400 To: [email protected] Subject: Re: Gump Failures Hey Craig, [EMAIL PROTECTED] wrote: <snip> > I am now working on the Pluto 1.1 admin portlet and have upgraded my > file upload code to use commons-fileupload 1.1, which is portlet > compatible. I will also upgrade the 1.0.2 branch to use > commons-fileupload 1.1. Cool! > I assume that this will fix the gump failure. Do > you agree? It may fix the gump failure, so lets give it a go :) Gump is building the portal module using the trunk of commons-fileupload. I'm not sure what purpose that serves, since we're using fileupload 1.0 and not trunk. Maybe I'm misunderstanding the purpose of gump. At any rate, the upgrade to fileupload 1.1 sounds like a possible solution, so if the errors still appear after the upgrade we can deal with it then? Does that sound ok? Elliot > /Craig > > -----Elliot Metsger <[EMAIL PROTECTED]> wrote: ----- > > >To: [email protected] > >From: Elliot Metsger <[EMAIL PROTECTED]> > >Date: 08/27/2006 01:38PM > >Subject: Re: Gump Failures > > > >Elliot Metsger wrote: > >> David, > >> > >> I looked at the Gump output a week or so ago... > >> > >>> [javac] > >>> > >/x1/gump/public/workspace/portals-pluto-1.0/portal/src/java/org/apach > >e/commons/fileupload/PortletFileUploadBase.java:290: > >>> cannot find symbol > >>> [javac] symbol : constructor > >>> MultipartStream(java.io.InputStream,byte[]) > >>> [javac] location: class > >org.apache.commons.fileupload.MultipartStream > >>> [javac] MultipartStream multi = new > >>> MultipartStream(input, boundary); > >> > >> It looks like a problem with the commons-fileupload dependency? > > > >Pluto Portal depends on commons-fileupload 1.0. The > >commons-fileupload > >trunk has removed the MultipartStream(java.io.InputStream,byte[]) > >constructor in r429098 [0]. As it stands, Pluto Portal won't be able > >to > >compile against commons-fileupload 1.2 when it is released. > > > >> It isn't clear to me (because I'm not familiar with Gump) - is Gump > > > >> building the 1.0.1 tag or are they pulling the 1.0.2 branch? > > > >Per the gump metadata [1], gump is building the pluto 1.0.2 branch. > >It > >also appears to be building commons-fileupload trunk. > > > >> As far as > >> I know there's nothing that has been done in the 1.0.2 branch that > >would > >> cause this (but I've been wrong before) > > > >See above. The build fails due to a change in the commons-fileupload > > > >MultipartStream class. > > > >> I can take responsibility for looking into this and figgurin' this > >one > >> out, seeing has how I've been the one messing around with 1.0.2 > >lately. > > > >How should we handle this? Update pluto's dependency to > >commons-fileupload 1.0.2-SNAPSHOT? Make pluto work with both > >commons-fileupload 1.0 and 1.2? Ignore it? > > > >Thanks for the advice, > >Elliot > > > >[0] svn diff -r 429097:429098 > >https://svn.apache.org/repos/asf/jakarta/commons/proper/fileupload/tr > >unk/src/java/org/apache/commons/fileupload/MultipartStream.java > > > >[1] > >http://svn.apache.org/repos/asf/gump/metadata/project/portals-pluto.x > >ml -------------------------------------------------------------------- mail2web - Check your email from the web at http://mail2web.com/ .
