[ http://issues.apache.org/jira/browse/PLUTO-261?page=comments#action_12455838 ] David DeWolf commented on PLUTO-261: ------------------------------------
I agree that this is some lousy logic, but I'm not convinced that is should be checking for the actionId. The PortalServletRequest is only used for rendering...actions should not come into play here and the parameters recieved from the url will all be render parameters. > PortalServletRequest makes a redundant check > -------------------------------------------- > > Key: PLUTO-261 > URL: http://issues.apache.org/jira/browse/PLUTO-261 > Project: Pluto > Issue Type: Bug > Components: portal driver > Affects Versions: 1.1.0-beta2 > Reporter: David Hay > Assigned To: David DeWolf > Fix For: 1.1.0 > > > On lines 95-96 of PortalServletRequest, the following code exists: > String id = portletWindow.getId().getStringId(); > if (portletWindow.getId().getStringId().equals(id)) { > This will always evaluate to true. What I suspect was intended here was the > following: > String id = portletWindow.getId().getStringId(); > if (url.getActionWindow().equals(id)) { > So that the query parameters were only included in the request for the > portlet processing an action. > BTW, 1.1.0-beta2 is still listed as unreleased in JIRA -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
