-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Christian, I will have a look on it, but not before the 04.12..
Torsten Christian Raschka (JIRA) schrieb: > [ > https://issues.apache.org/jira/browse/PLUTO-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Christian Raschka updated PLUTO-444: > ------------------------------------ > > Attachment: filters.271107.patch > > Here is my next version. It should now be spec conform as i have described > above. > > The portlet instance is set to the filterchain and the render (processAction > etc.) is done there if no (more) filters are present. > > Please review it. > > TODO: The Filters need a refactoring (merge things used in all lifecycles) > >> Filter chain is not implemented the right way >> --------------------------------------------- >> >> Key: PLUTO-444 >> URL: https://issues.apache.org/jira/browse/PLUTO-444 >> Project: Pluto >> Issue Type: Sub-task >> Components: portal driver >> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge >> Reporter: Christian Raschka >> Priority: Critical >> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge >> >> Attachments: filter.231107.patch, filters.271107.patch >> >> >> In my opinion portlet filter should work the same way like servlet filters >> do: >> An example: If you have a filter chain with filters F1 and F2, then the >> chain is: F1 -> F2 -> target -> F2 -> F1. >> An exception is, if a Filter does not call filterChain.doFilter. Then no >> other filter _or_ the target is invoked and the filter itself is responsible >> for the response. >> (e.g. see http://java.sun.com/products/servlet/Filters.html) >> In the current implementation the target is invoked, no matter if a filter >> blocks the chain or not. > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHTSzj0Ji0BqEIlIURAvfRAJ9BW3TbrBm5OtWzau5yYpKuKZibegCeOAdR PckqWnYeUb6jrDzR8yUfYV4= =sHXV -----END PGP SIGNATURE-----
