[
https://issues.apache.org/jira/browse/PLUTO-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553718
]
Craig Doremus commented on PLUTO-367:
-------------------------------------
In working on these Public Render Parameter tests, I found that line 167 in
RelativePortalURLImpl (clearParameters() method) threw a NullPointerException
because the window ID was null for public render parameters (the
PortalURLParameter.getWindow() call returns null). I stuck a null check there
and it worked.
However I noticed a number of other places where PortalURLParameter.getWindow()
id was called and some of them did not have a null check. I can also stick null
checks where they are missing, but I want to make sure this does not have
unintended consequences. Torsten (or anyone else), can you comment on this?
BTW, my tests indicate that if a public render parameters is not declared by a
supported-public-render-parameter element in a portlet.xml record of a portlet
instance, then the portlet window does not see it. This is proper behaviour
according to the JSR-286 spec. I will add that check and others to this
testsuite test.
> Add public render parameters tests to testsuite for JSR-286
> -----------------------------------------------------------
>
> Key: PLUTO-367
> URL: https://issues.apache.org/jira/browse/PLUTO-367
> Project: Pluto
> Issue Type: Test
> Components: portlets-testsuite
> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Environment: All
> Reporter: Craig Doremus
> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
>
> A testsuite test needs to be created to test JSR-286 shared render
> parameters. This is necessary to make sure merging the 1.1-286-COMPATIBILITY
> branch with the Pluto trunk and any other 1.1-286-COMPATIBILITY branch
> refactorings does not break this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
