-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dear Craig, I apologize, you are absolutely correct with your complains about those commits. I tried to fix all those TODOs and FIXMEs in a long night session which was apparantly too long. I should have done it more carefully, I'm sorry.
To hopefully resolve the issue, I suggest to prepare another patch which fixes the issues left unfixed by my previous commits and tags those still unfixed with TODO and FIXME tags again. Best regards, Torsten [EMAIL PROTECTED] schrieb: | Torsten, | | I very much appreciated the work you and your group has done to create | Pluto 2.0, but I was very disappointed in many of the commits you did | today. Rather than fixing most of the TODOs and FIXMEs, you just erased | them. Some of the TODOs and FIXMEs are inconsequential and not necessary | and should be erased and some FIXMEs are not that important and should be | changed to TODOs. But many of these should have been fixed before the FIXME | or TODO was removed. | | Here are a few specific comments: | 1. Many of the TODOs are those automatically added by Eclipse and are | labelled "Auto-generated catch block" and include a printStackTrace() call | to stdout. This should have been changed to log to Pluto's log file | including a relevant message and the exception so the stack trace will | appear in the Pluto log. Consideration should also be made to rethrow the | exception so it is propagated up the stack trace to the user. | 2. The FIXME in SupportedModesServiceImpl.isPortletManagedMode() refers to | the fact that this method is not properly implemented and had notes on how | to implement the method. You just erased the FIXME and notes rather than | fixing the method as detailed in the FIXME comment. | 3. In PortletURLTag286.doStartTag(), rather than implementing the FIXME | suggestion, you just erased the FIXME and the suggested code that was | commented out. | | I think the commits where FIXMEs and TODOs are just erased should be rolled | back except in those cases where the FIXME or TODO does not add value or | the issue pointed out by the FIXME or TODO was fixed. Does anybody else | have this opinion or am I making too much out of nothing here? | -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHjNYL0Ji0BqEIlIURAl6PAJ9zPnjWF44s+nc/6YU7N0QxRjsJeQCffBkD 2Dpm3ixs4yHGs4p8JgMMtNk= =TcUz -----END PGP SIGNATURE-----
