[
https://issues.apache.org/jira/browse/PLUTO-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606844#action_12606844
]
David Jencks commented on PLUTO-437:
------------------------------------
This looks pretty unobjectionable to me, does anyone object if I apply the
patch?
to make review possibly easier, the main change here is:
Index:
pluto-portal-driver/src/main/java/org/apache/pluto/driver/services/portal/PageConfig.java
===================================================================
---
pluto-portal-driver/src/main/java/org/apache/pluto/driver/services/portal/PageConfig.java
(revision 652071)
+++
pluto-portal-driver/src/main/java/org/apache/pluto/driver/services/portal/PageConfig.java
(working copy)
@@ -25,6 +25,7 @@
private String name;
private String uri;
+ private String icon;
private Collection portletIds;
private int orderNumber;
@@ -78,4 +79,12 @@
return getName().hashCode() + "|"+portletIds.size();
}
+ public String getIcon() {
+ return icon;
+ }
+
+ public void setIcon(String icon) {
+ this.icon = icon;
+ }
+
}
Index: pluto-portal-driver/src/main/resources/pluto-portal-driver-config.xsd
===================================================================
--- pluto-portal-driver/src/main/resources/pluto-portal-driver-config.xsd
(revision 652071)
+++ pluto-portal-driver/src/main/resources/pluto-portal-driver-config.xsd
(working copy)
@@ -59,6 +59,8 @@
type="xs:string" />
<xs:attribute name="uri"
type="xs:string" />
+
<xs:attribute name="icon"
+
type="xs:string" />
</xs:complexType>
</xs:element>
</xs:sequence>
plus some (possibly optional) modifications to use the new feature in
pluto-portal/src/main/resources/pluto-portal-driver-config.xml,
pluto-portal/src/main/webapp/WEB-INF/themes/navigation.jsp, and
pluto-portal/src/main/webapp/pluto.css
> Icon support for portal pages listed in the navigation area
> -----------------------------------------------------------
>
> Key: PLUTO-437
> URL: https://issues.apache.org/jira/browse/PLUTO-437
> Project: Pluto
> Issue Type: Improvement
> Components: portal driver
> Affects Versions: 2.0.0, 1.2.0, 1.1.6
> Reporter: Paul McMahan
> Fix For: 2.0.0, 1.1.6
>
> Attachments: P437-1.1.x-Rev652071.diff, PLUTO-437-images.zip,
> PLUTO-437.diff, PLUTO-437.png
>
>
> This is a request for an improvement to the portal driver that would allow
> for the optional display of an icon for each portal page listed in the
> navigation area.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
