[
https://issues.apache.org/jira/browse/PLUTO-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680512#action_12680512
]
Ate Douma commented on PLUTO-537:
---------------------------------
Finally, I've started removing the PortalCallbackService by moving its
containing methods to other more direct and appropriate "service" access
interfaces.
The PortalCallbackService as a separate service interface really wasn't adding
any technical or functional benefit anyway, as it was provided by the
RequiredContainerServices, so needed to be implemented by the embedding Portal
just as well.
I've added a FilterManagerService (also allows to better maintain a cached
FilterChain state instead of creating a new on each request) to access a
FilterManager.
The getFilterManager method is moved from the PortalCallbackService to this new
FilterManagerService, which itself is added (up) to the
RequiredContainerServices directly.
The getPortletURLListener() is also moved up to the RequiredContainerServices,
and all the other methods in PortalCallBackService are moved to the response
specific -Context interface where they are (only) used:
- getResourceURLProvider -> PortalResponseContext
- getPortletURLProvider -> PortletMimeResponseContext
- getEventProvider -> PortletStateAwareResponseContext
This leaves an empty PortalCallbackService and thus can be removed.
> Cleaning up Pluto packages
> --------------------------
>
> Key: PLUTO-537
> URL: https://issues.apache.org/jira/browse/PLUTO-537
> Project: Pluto
> Issue Type: Task
> Components: portlet container
> Affects Versions: 2.0.0
> Reporter: Ate Douma
> Assignee: Ate Douma
> Fix For: 2.0.0
>
>
> A cleaning up of the current Pluto packages was proposed initially by Casten
> on the dev list, see:
> http://www.nabble.com/-RT--Cleaning-up-our-packages-p22288945.html
> A follow up proposal was accepted on the dev list, see:
> http://www.nabble.com/Re%3A--RT--Cleaning-up-our-packages-p22414927.html
> defining the following changes which will be done:
> container-api:
> - o.a.p
> leave as is
> - o.a.p.core
> rename to o.a.p.driver
> move NullPortlet as inner class to PortletServlet
> - o.a.p.services
> move PortletAppDescriptorServices to o.a.p.spi
> move ContainerServices to o.a.p
> move PlutoServices to o.a.p.driver (side-by-side PortletServlet)
> - o.a.p.om.portlet
> leave as is
> - o.a.p.internal
> rename Internal* to Container* (I really don't like the "Internal"
> prefix)
> move * to o.a.p
> - o.a.p.spi.optional
> move * to o.a.p.spi
> the distinction between spi and spi.optional (while somewhat useful
> configuration wise) really is too artificial technical wise imo.
> container (impl):
> - o.a.p
> move PortletContainerFactory to o.a.p.driver.impl
> - o.a.p.core
> move the following to new package o.a.p.impl
> ContainerInvocation* (note: I've some ideas to completely get rid of
> these all together)
> PlutoContainerServices
> PortletContainerImpl
> move all the others to either
> - o.a.p.driver.impl (those which really are used only by/for a
> standalone/pure embedded driver)
> - o.a.p.spi.impl (those which are of more generic usage and/or
> embedding in a larger portal)
> drop package o.a.p.core
> - o.a.p.descriptors.portlet, o.a.p.descriptors.portlet10
> rename these to o.a.p.om.portlet.impl and o.a.p.om.portlet10.impl
> - o.a.p.descriptors.services.jaxb
> move PortletAppDescriptorServiceImpl to o.a.p.spi.impl
> - o.a.p.internal.impl
> move * to o.a.p.impl
> - o.a.p.util
> move to o.a.p.impl.util
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
