[ 
https://issues.apache.org/jira/browse/PLUTO-561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ate Douma resolved PLUTO-561.
-----------------------------

    Resolution: Fixed

Thanks again for the patch Mike.
I've applied and tested it, works fine, so committed now as well.

> ResourceResponse.setContentType() with charset is broken.
> ---------------------------------------------------------
>
>                 Key: PLUTO-561
>                 URL: https://issues.apache.org/jira/browse/PLUTO-561
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container
>    Affects Versions: 2.0.0
>            Reporter: Michael Freedman
>            Assignee: Ate Douma
>             Fix For: 2.0.0
>
>         Attachments: pluto_561.patch
>
>
> ResourceResponseImpl.setCharacterSetEncoding (and setContentType) has 
> problems.  If the content type contains a charset (text/xml;charset=utf-8), 
> the setContentType calls setCharacterSetEncoding on "charset=utf-8" vs. 
> utf-8.  And setCharacterSetEncoding doesn't adjust accordingly.  Also 
> setCharacterSetEncoding using a previous (data member) value to set the 
> responseContext vs. the new one passed in.  Altogether it breaks resources 
> that set a contenttype that includes a charset.  I have attached a patch file 
> that addresses these problems by altering setCharacterSetEncoding to deal 
> with strings that contain the full charset=xxxx encoding.  You might prefer 
> instead to just fix setContentType to do the right thing and require/expect 
> all clients to also do the right thing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to