[
https://issues.apache.org/jira/browse/PLUTO-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ate Douma updated PLUTO-567:
----------------------------
Attachment: PLUTO-567-patch-cleaned-up.patch
Hi Gonzalo,
First of all, please make sure to provide easily apply able and clean patches.
Your patch seemed to be a hand-merged set of patches into a single file, for
different svn root folders.
As result, I had to break it up again myself first.
Furthermore, having unrelated (like the one for PLUTO-565) or unneeded changes
mixed in really is bad practice.
As reference I'm attaching a new clean patch file with only the relevant
changes for this issue, created using "$svn diff >
PLUTO-567-patch-cleaned-up.patch" from the root folder.
About your proposed changes:
First of all, I haven't tested these out, so this is only a preliminary review.
- PortletContainerImpl.java
Guarding against a null PortletWindow during (only render!) should not be
needed: it is the responsibility of the invoking Portal to ensure required
parameters are provided, otherwise don't call the container. So this change is
not OK.
- PortletTag.java
Change seems OK to me, except a more descriptive message, like mentioning the
portletId for the non-available portlet, should be provided.
Also, strip out the FIXME comment.
- PortletModeDropDownTag.java
Seems OK too, however the FIXME comment should be replaced with a better
description why the exception is ignored.
- PortletTitleTag.java
Looks OK, maybe replace "[Unknown]" with "[Unknown -
"+parentTag.getPortletId()+"]"
> Make Pluto work even if main portlets are not available.
> --------------------------------------------------------
>
> Key: PLUTO-567
> URL: https://issues.apache.org/jira/browse/PLUTO-567
> Project: Pluto
> Issue Type: Bug
> Reporter: Gonzalo Aguilar
> Fix For: 2.0.1
>
> Attachments: handle-config-and-portlet-missing.patch,
> PLUTO-567-patch-cleaned-up.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Pluto stops when a portlet is not available to the container.
> A small patch will be provided to let the container run even if no portlets
> are available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
