alter return types in org.apache.pluto.container.om.portlet.Filter?
-------------------------------------------------------------------

                 Key: PLUTO-589
                 URL: https://issues.apache.org/jira/browse/PLUTO-589
             Project: Pluto
          Issue Type: Improvement
          Components: portlet container
    Affects Versions: 2.0.0
            Reporter: Nicholas Blair


The return type for the getInitParams() method in 
org.apache.pluto.container.om.portlet.Filter is List<? extends InitParam>.
This presents an awkward scenario, one particularly present when creating unit 
tests for a FilterChain implementation and attempting to create mock Filter 
implementations.

The requirement that getInitParams return a class that implements an interface 
_that extends_ InitParam. You cannot simply return a class that implements 
InitParam; you would need to define your own custom interface that extends 
InitParam, and implement your custom interface.

If the InitParam interface satisfactorily defines what's needed, the 
getInitParams return should be a class that simply implements InitParam.

Is it possible to modify the return value for getInitParams to simply?
 List<InitParam> 

This also applies to the getDescriptions and getDisplayNames method in the same 
class; both have return values of List<? extends someinterface>, it should 
simply be List<interface>.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to