[
https://issues.apache.org/jira/browse/PLUTO-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924203#action_12924203
]
Ate Douma commented on PLUTO-601:
---------------------------------
Completely right, nice observation :)
I think to be on the safe side, yes we should instantiate even de
DocumentBuilderFactory every time, or make the usage synchronized which I don't
advise.
All in all, I wouldn't think this service causing lots of memory/performance
overhead is it? And the (webapp) loading by itself most likely will account for
a multitude of that anyway.
> Remove expensive object creation in PortletAppDescriptorServiceImpl
> -------------------------------------------------------------------
>
> Key: PLUTO-601
> URL: https://issues.apache.org/jira/browse/PLUTO-601
> Project: Pluto
> Issue Type: Improvement
> Components: portlet container
> Reporter: Eric Dalquist
> Assignee: Eric Dalquist
> Fix For: 2.0.3, 2.1.0
>
>
> PortletAppDescriptorServiceImpl creates new JAXBContext, XMLInputFactory,
> DocumentBuilderFactory, and Pattern objects every time they are needed. All
> of these objects are thread-safe once created and configured and should only
> be created once at the class level and re-used for the life of the class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
