[
https://issues.apache.org/jira/browse/PLUTO-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934693#action_12934693
]
Eric Dalquist commented on PLUTO-598:
-------------------------------------
So my primary concern here is the when the portal wants to have complete
control the request attributes a portlet sees when getAttribute() is called on
the PortletRequest or the ServletRequest based on the PortletRequest. The
primary issue I was trying to address with PLUTO-600 was having the fallback
logic in the HttpServletPortletRequestWrapper means that there is no reasonable
way for a portal to influence this attribute resolution logic. My request is
that if at all possible this logic should be part of the default
PortletRequestContext SPI implementation so that implementing portals can still
have full control over this attribute resolution.
> Retrieving Portlet invoked servlet request attributes should first check
> PortletRequest attributes before using fallback to the web container
> ----------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PLUTO-598
> URL: https://issues.apache.org/jira/browse/PLUTO-598
> Project: Pluto
> Issue Type: Bug
> Components: portlet container
> Affects Versions: 2.0.2
> Reporter: Ate Douma
> Assignee: Ate Douma
> Fix For: 2.0.3, 2.1.0
>
>
> In
> o.a.pluto.container.impl.HttpServletPortletRequestWrapper.getAttribute(String)
> a (non path related) attribute currently first is looked up from
> getRequest().getAttribute(String) with a fallback to the
> PortletRequest.getAttribute(String).
> However, this is the wrong order: first the
> PortletRequest.getAttribute(String) should be checked to ensure a possibly
> earlier set attribute which is *only* set with
> PortletRequest.setAttribute(String,Object) (and possibly cached there) is
> returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
