Neil Griffin created PLUTO-729:
----------------------------------
Summary: TCK: Contesting usage of upper-case portlet modes and
window states in Portlet Hub tests
Key: PLUTO-729
URL: https://issues.apache.org/jira/browse/PLUTO-729
Project: Pluto
Issue Type: Bug
Components: tck
Affects Versions: 3.0.1, 3.0.0
Reporter: Neil Griffin
Assignee: Neil Griffin
Fix For: 3.0.2
This issue challenges the usage of *upper case* portlet modes and window states
in Portlet Hub tests.
The [JSDoc for the Portlet Hub
setPortletMode|https://github.com/apache/portals-pluto/blob/master/portlet-api/src/main/javascript/portlet.js#L66-L67]
function states:
{quote}The strings defined by the {@link PortletConstants} object should be
used to specify the portlet mode.{quote}
In addition, the [JSDoc for the Portlet Hub setWindowState
function|https://github.com/apache/portals-pluto/blob/master/portlet-api/src/main/javascript/portlet.js#L71]
states:
{quote} The strings defined by the {@link PortletConstants} object should be
used to specify the window state.{quote}
The [portlet constants are defined in the
JSDoc|https://github.com/apache/portals-pluto/blob/master/portlet-api/src/main/javascript/portlet.js#L88-L93]
with *lower case* values:
{code:javascript|title=portlet.js}
* @property {string} VIEW Specifies portlet mode 'view'
* @property {string} EDIT Specifies portlet mode 'edit'
* @property {string} HELP Specifies portlet mode 'help'
* @property {string} NORMAL Specifies window state 'normal'
* @property {string} MINIMIZED Specifies window state 'minimized'
* @property {string} MAXIMIZED Specifies window state 'maximized'
{code}
However, certain Portlet Hub related TCK tests are using an *upper case* value.
For example,
[V3PortletHubTests_SPEC_23_JSState_clone3|https://github.com/apache/portals-pluto/blob/master/portlet-tck_3.0/V3PortletHubTests/src/main/webapp/javascript/PortletHubTests_SPEC_23_JSState.js#L262-L263]
has:
{code:javascript}
state.setPortletMode('VIEW');
state.setWindowState('NORMAL');
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
