Re: Patch for maven-pluto-plugin

[David H. DeWolf]

Awesome, thanks.  I'll apply it tomorrow.

David

Stefan Armbruster wrote:

Hi,

I got trouble when running the current (aka svn head) version of maven-pluto-plugin with official Maven 2.0.

When deploying the portlet app using "mvn portlet:deploy", I get this:

java.lang.NoSuchMethodError: org.apache.maven.project.MavenProject.getProfileProperties()Ljava/util/Properties; at org.apache.pluto.maven.DeployMojo$DeploymentConfigImpl.<init>(DeployMojo.java:76)

        at org.apache.pluto.maven.DeployMojo.createConfig(DeployMojo.java:62)
        at org.apache.pluto.maven.DeployMojo.doExecute(DeployMojo.java:57)

at org.apache.pluto.maven.AbstractPlutoMojo.execute(AbstractPlutoMojo.java:48) at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:399) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:519) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:482) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:452) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:301) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:268) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:137)

        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:316)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:113)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:249)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

        at java.lang.reflect.Method.invoke(Method.java:585)
        at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
        at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)

at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)

        at org.codehaus.classworlds.Launcher.main(Launcher.java:375)

The cause for this is that maven-pluto-plugin relies on maven-2.0-alpha3. Maven 2.0 final does not contain MavenProject.getProfileProperties(), instead MavenProject.getProperties() must be used.

I've attached a patch contains the pom.xml and DeployMojo.java changes for using Maven 2.0 final dependencies.

Regards,
Stefan


------------------------------------------------------------------------

Index: 
/home/stefan/Programming/mindblast/workspace/pluto-1.1/maven-pluto-plugin/pom.xml
===================================================================
--- 
/home/stefan/Programming/mindblast/workspace/pluto-1.1/maven-pluto-plugin/pom.xml
   (revision 328950)
+++ 
/home/stefan/Programming/mindblast/workspace/pluto-1.1/maven-pluto-plugin/pom.xml
   (working copy)
@@ -13,7 +13,7 @@
      <dependency>
        <groupId>org.apache.maven</groupId>
        <artifactId>maven-core</artifactId>
-       <version>2.0-alpha-3</version>
+       <version>2.0</version>
      </dependency>
      <dependency>
        <groupId>org.apache.pluto</groupId>
@@ -24,7 +24,7 @@
      <dependency>
        <groupId>org.apache.maven</groupId>
        <artifactId>maven-artifact</artifactId>
-       <version>2.0-alpha-3</version>
+       <version>2.0</version>
      </dependency>
      <dependency>
        <groupId>org.apache.maven</groupId>
@@ -29,7 +29,7 @@
      <dependency>
        <groupId>org.apache.maven</groupId>
        <artifactId>maven-model</artifactId>
-       <version>2.0-alpha-3</version>
+       <version>2.0</version>
      </dependency>
      <dependency>
        <groupId>org.apache.maven</groupId>
@@ -34,7 +34,7 @@
      <dependency>
        <groupId>org.apache.maven</groupId>
        <artifactId>maven-project</artifactId>
-       <version>2.0-alpha-3</version>
+       <version>2.0</version>
      </dependency>
      <dependency>
        <groupId>org.apache.maven</groupId>
@@ -39,7 +39,7 @@
      <dependency>
        <groupId>org.apache.maven</groupId>
        <artifactId>maven-plugin-api</artifactId>
-       <version>2.0-alpha-3</version>
+       <version>2.0</version>
      </dependency>
      <dependency>
        <groupId>marmalade</groupId>
@@ -59,7 +59,7 @@
      <dependency>
        <groupId>org.apache.maven</groupId>
        <artifactId>maven-script-marmalade</artifactId>
-       <version>2.0-alpha-3</version>
+       <version>2.0-beta-2</version>
      </dependency>
    </dependencies>

Index: /home/stefan/Programming/mindblast/workspace/pluto-1.1/maven-pluto-plugin/src/main/java/org/apache/pluto/maven/DeployMojo.java

===================================================================
--- 
/home/stefan/Programming/mindblast/workspace/pluto-1.1/maven-pluto-plugin/src/main/java/org/apache/pluto/maven/DeployMojo.java
      (revision 328950)
+++ 
/home/stefan/Programming/mindblast/workspace/pluto-1.1/maven-pluto-plugin/src/main/java/org/apache/pluto/maven/DeployMojo.java
      (working copy)
@@ -73,7 +73,7 @@

public DeploymentConfigImpl() {

             super(deployment.getName().substring(0, 
deployment.getName().lastIndexOf(".")));
-            props = new Properties(project.getProfileProperties());
+            props = new Properties(project.getProperties());
             props.putAll(System.getProperties());
             props.setProperty("tomcat.home", 
installationDirectory.getAbsolutePath());
             props.setProperty("tomcat.service", tomcatService);