Send plymouth mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://lists.freedesktop.org/mailman/listinfo/plymouth
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of plymouth digest..."
Today's Topics:
1. Re: plymouth performance (Ray Strode)
2. Re: plymouth performance (Charlie Brej)
----------------------------------------------------------------------
Message: 1
Date: Wed, 17 Jun 2009 00:16:46 -0400
From: Ray Strode <[email protected]>
Subject: Re: plymouth performance
To: Charlie Brej <[email protected]>
Cc: [email protected]
Message-ID:
<[email protected]>
Content-Type: text/plain; charset=UTF-8
Hey,
On Mon, Jun 15, 2009 at 3:29 PM, Charlie Brej<[email protected]> wrote:
> On 12/06/09 04:52, Ray Strode wrote:
>>
>> Instead of having one bounding box of what to flush, I now keep a list
>> of rectangles and flush them one by one.
>> Since the rectangles can in theory overlap, I had a little logic to
>> try to eliminate duplicate work, but it's not as sophisticated as it
>> could be.
>
> Could you take a look at this patch? It is a bit complicated but I think it
> does the job.
Looks pretty good to me. Two comments:
1) The function is huge, it would be better if it were broken up into
sub functions for the various parts
2) The numbers and bit fiddling are sort of cryptic. I think it would
be clearer to use enums.
If you don't want to fix those things up, it's not a big deal. I can
rework it later. Feel free to commit either way.
> it may be an idea to create a "ply-area" in libply to reuse the code.
Makes sense to me. Atlhough I'd probably call it ply-region just
because "area" makes me think of a rectangle,
not a list of rectangles (and that type of structure is called a
region in Xlib / GDK programming too).
Another item for for the todo list, I guess.
> I have in the past used callgrind and kcachegrind for profiling plymouth,
> with an added bonus of being able to see how the program behaves on a ~10
> times slower system.
Did you find any hot spots? I should probably do a run with sysprof
and see where the time is being spent that way.
--Ray
------------------------------
Message: 2
Date: Wed, 17 Jun 2009 11:29:31 +0100
From: Charlie Brej <[email protected]>
Subject: Re: plymouth performance
To: Ray Strode <[email protected]>
Cc: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
On 17/06/09 05:16, Ray Strode wrote:
>> I have in the past used callgrind and kcachegrind for profiling plymouth,
>> with an added bonus of being able to see how the program behaves on a ~10
>> times slower system.
> Did you find any hot spots? I should probably do a run with sysprof
> and see where the time is being spent that way.
Attached are the call graphs for the 4 graphical plugins each running for 20
seconds. The gradient using rand uses quite a lot which could be replaced with
a
dither. I'll take a look.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: charge.ps.gz
Type: application/x-gzip
Size: 5429 bytes
Desc: not available
Url :
http://lists.freedesktop.org/archives/plymouth/attachments/20090617/0574bf6f/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fade-in.ps.gz
Type: application/x-gzip
Size: 5169 bytes
Desc: not available
Url :
http://lists.freedesktop.org/archives/plymouth/attachments/20090617/0574bf6f/attachment-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: solar.ps.gz
Type: application/x-gzip
Size: 3936 bytes
Desc: not available
Url :
http://lists.freedesktop.org/archives/plymouth/attachments/20090617/0574bf6f/attachment-0002.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: spinfinity.ps.gz
Type: application/x-gzip
Size: 4709 bytes
Desc: not available
Url :
http://lists.freedesktop.org/archives/plymouth/attachments/20090617/0574bf6f/attachment-0003.bin
------------------------------
_______________________________________________
plymouth mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/plymouth
End of plymouth Digest, Vol 9, Issue 5
**************************************
