On Sat, 2008-03-15 at 21:07 +0100, Michael Biebl wrote: > 2008/3/15, Michael Biebl <[EMAIL PROTECTED]>: > > > 1.) pm/module.d/uswsusp: > > Now that it disables the 99video hook, it has to parse the quirks > > itself and pass it to s2ram in do_suspend and s2both in > > do_suspend_hybrid > > This also means, that help() in pm-action.in should also take this into > account. > It should not only run the help() method of all hooks, but also that > of the used sleep module, as the sleep module could have module > specific command line options.
Good idea. Implemented and pushed upstream. HOWTO.modules has the necessary implementation documentation. For obvious reasons, the module method cannot be named "help" -- we source the sleep module, and there is that whole flat namespace thing. > Btw: > pm-hibernate --help > pm-hibernate [options] > > Options can change how suspend or hibernate is done. > Sa 15. Mär 21:04:00 CET 2008: running /usr/lib/pm-utils/sleep.d/00clear help > success. > Sa 15. Mär 21:04:00 CET 2008: running /usr/lib/pm-utils/sleep.d/05led help > not applicable. > Sa 15. Mär 21:04:00 CET 2008: running > /usr/lib/pm-utils/sleep.d/10NetworkManager help > not applicable. > Sa 15. Mär 21:04:00 CET 2008: running /usr/lib/pm-utils/sleep.d/49bluetooth > help > not applicable. > Sa 15. Mär 21:04:00 CET 2008: running /usr/lib/pm-utils/sleep.d/50modules help > not applicable. > Sa 15. Mär 21:04:00 CET 2008: running /usr/lib/pm-utils/sleep.d/90clock help > not applicable. > Sa 15. Mär 21:04:00 CET 2008: running /usr/lib/pm-utils/sleep.d/94cpufreq help > not applicable. > Sa 15. Mär 21:04:00 CET 2008: running /usr/lib/pm-utils/sleep.d/95led help > not applicable. > Sa 15. Mär 21:04:00 CET 2008: running /usr/lib/pm-utils/sleep.d/99video help > disabled > > > I guess, that's not really how we would like to have it ;-) You are correct. Fixed and pushed upstream. > Cheers, > Michael > > -- Victor Lowther Ubuntu Certified Professional _______________________________________________ Pm-utils mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pm-utils
