On Mon, 2008-03-17 at 00:31 +0100, Michael Biebl wrote: > 2008/3/16, Victor Lowther <[EMAIL PROTECTED]>: > > On Sun, 2008-03-16 at 18:50 +0100, Michael Biebl wrote: > > > > > Hi, > > > > > > attached is the patch, which parses the video quirks in the uswsusp > > > sleep module and passes this options to s2ram/s2both. > > > > > > In the get_quirks code, ACPI_SLEEP should be initailized to 0, not "". > > Shell arithmetic may break otherwise, depending on your shell. > > Ok, fixed. > > > > > Otherwise, the patch looks fine. > > > > Pushed, together with the removal of pm/module.d/README.uswsusp.
After a bit more review, your patch was not honoring QUIRK_NONE. I readded support for it and pushed changes upstream. You may also want to prefix the environment variables you introduce in uswsusp with USWSUSP_ to prevent future namespace collisions. > Cheers, > Michael > -- Victor Lowther Ubuntu Certified Professional _______________________________________________ Pm-utils mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pm-utils
