On Tue, 2008-10-07 at 02:06 +0200, Michael Biebl wrote:
> 2008/10/7 Victor Lowther <[EMAIL PROTECTED]>:
> > On Mon, 2008-10-06 at 18:30 +0200, Michael Biebl wrote:
> >> 2008/10/6 Stefan Seyfried <[EMAIL PROTECTED]>:
> >> > Michael Biebl wrote:
> >> >> 2008/10/4 Victor Lowther <[EMAIL PROTECTED]>:
> >> >
> >> >> I also wonder, if we shouldn't always reset acpi_flags to 0.
> >> >
> >> > IMHO yes, you should. s2ram is doing this for quite some time now after
> >> > I was
> >> > chasing some strange bug reports. This also gets rid of people still
> >> > using
> >> > "acpi_sleep=s3_bios,s3_mode" on the kernel command line and then telling
> >> > you
> >> > "My machine does not need any quirks!!!11!"
>
> Ok, should we use the following then? (this would basically be what s2ram
> does):
>
> diff --git a/pm/sleep.d/99video b/pm/sleep.d/99video
> index 0beb360..1fe54c2 100755
> --- a/pm/sleep.d/99video
> +++ b/pm/sleep.d/99video
> @@ -144,7 +144,7 @@ suspend_video()
> local acpi_flag=0
> quirk "${QUIRK_S3_BIOS}" && acpi_flag=$(($acpi_flag + 1))
> quirk "${QUIRK_S3_MODE}" && acpi_flag=$(($acpi_flag + 2))
> - [ 0 -ne $acpi_flag ] && sysctl -w kernel.acpi_video_flags=$acpi_flag
> + sysctl -w kernel.acpi_video_flags=$acpi_flag
>
> quirk "${QUIRK_NOFB}" && die_if_framebuffer
> quirk "${QUIRK_VBESTATE_RESTORE}" && vbe_savestate
> @@ -166,8 +166,6 @@ resume_video()
> quirk "${QUIRK_RADEON_OFF}" && radeon_on
> quirk "${QUIRK_DPMS_ON}" && vbe dpms on
> quirk "${QUIRK_RESET_BRIGHTNESS}" && reset_brightness
> - # always reset acpi_video_flag -- makes quirk testing more reliable.
> - sysctl -w kernel.acpi_video_flags=0
> return 0 # avoid spurious hook exit failure message.
> }
Sure, push it to master.
--
Victor Lowther
Ubuntu Certified Professional
_______________________________________________
Pm-utils mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/pm-utils
