Branch: refs/heads/master
Home: https://github.com/pmd/pmd
Commit: 230fc4c805367a13afd6ca2c928b2489a175eb1b
https://github.com/pmd/pmd/commit/230fc4c805367a13afd6ca2c928b2489a175eb1b
Author: Scott Wells <sc...@illuminatedcloud.com>
Date: 2021-10-20 (Wed, 20 Oct 2021)
Changed paths:
M
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/bestpractices/ApexUnitTestClassShouldHaveAssertsRule.java
M pmd-apex/src/main/resources/category/apex/bestpractices.xml
M
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/bestpractices/xml/ApexUnitTestClassShouldHaveAsserts.xml
Log Message:
-----------
Issue 1089 - Added a new configuration property,
'additionalAssertMethodPattern', that when specified is also evaluated against
each invoked method name to determine whether it represents a test assertion.
This will provide support for those who use testing facades such as
sirono-common's Assert, or who encapsulate common assertions in local utility
methods.
Commit: dc0e1ee17f1e18123e8fd42ea66ca1fba2e0cd91
https://github.com/pmd/pmd/commit/dc0e1ee17f1e18123e8fd42ea66ca1fba2e0cd91
Author: Scott Wells <sc...@illuminatedcloud.com>
Date: 2021-10-22 (Fri, 22 Oct 2021)
Changed paths:
M
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/bestpractices/ApexUnitTestClassShouldHaveAssertsRule.java
M
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/bestpractices/xml/ApexUnitTestClassShouldHaveAsserts.xml
Log Message:
-----------
Changes based on review feedback, specifically:
1) Only try to compile the configured pattern once if provided for both
efficiency and noise suppression reasons. The suggested dysfunctionReason()
approach was not used because that doesn't seem to be called when executing for
unit tests. Happy to revisit this if I'm just missing something.
2) Catch more specific exceptions, in this case IllegalArgumentException which
is thrown by Pattern#compile both as that type and as its sub-type
PatternSyntaxException.
3) Document why we're using a string property and not a regex property so that
we can control the pattern compilation params.
4) Add expected failure line numbers to the new test case.
Commit: e1d4a29e94b8e6a50dd31ca8ca307aa6a09ec654
https://github.com/pmd/pmd/commit/e1d4a29e94b8e6a50dd31ca8ca307aa6a09ec654
Author: Robert Sösemann <8180281+rsoesem...@users.noreply.github.com>
Date: 2021-10-22 (Fri, 22 Oct 2021)
Changed paths:
M
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/bestpractices/ApexUnitTestClassShouldHaveAssertsRule.java
M pmd-apex/src/main/resources/category/apex/bestpractices.xml
M
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/bestpractices/xml/ApexUnitTestClassShouldHaveAsserts.xml
Log Message:
-----------
Merge pull request #3571 from SCWells72/pmd-1089
Compare: https://github.com/pmd/pmd/compare/02af52702669...e1d4a29e94b8
_______________________________________________
Pmd-commits mailing list
Pmd-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/pmd-commits
