Branch: refs/heads/master
Home: https://github.com/pmd/pmd
Commit: e0cd2a6ae2ab5a9dd2b6306fe4a14aaeec70fb01
https://github.com/pmd/pmd/commit/e0cd2a6ae2ab5a9dd2b6306fe4a14aaeec70fb01
Author: Scott Wells <sc...@illuminatedcloud.com>
Date: 2021-10-23 (Sat, 23 Oct 2021)
Changed paths:
M
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/ast/AbstractApexCommentContainerNode.java
M
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/ast/ApexTreeBuilder.java
Log Message:
-----------
Made the check for whether a node contains comments more efficient. Instead
of having to inspect all commented lines in the file for each comment
container, we now pre-calculate an index of which lines were comments, and then
we see whether any of the lines in a comment container's range are flagged in
that index. Given that we're currently only going to perform this logic for
ASTCatchBlockStatement nodes, hopefully this should be very efficient. If/when
this logic is expanded to include other node types, we can revisit and
determine whether another approach such as a binary search for lines in a given
range is a better fit.
Made AbstractApexCommentContainerNode package-private.
Commit: 591d6c64ad7d05d1c6569233eca9cf0ba1e553ec
https://github.com/pmd/pmd/commit/591d6c64ad7d05d1c6569233eca9cf0ba1e553ec
Author: Robert Sösemann <8180281+rsoesem...@users.noreply.github.com>
Date: 2021-10-23 (Sat, 23 Oct 2021)
Changed paths:
M
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/ast/AbstractApexCommentContainerNode.java
M
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/ast/ApexTreeBuilder.java
Log Message:
-----------
Merge pull request #3581 from SCWells72/pmd-3569-feedback
Compare: https://github.com/pmd/pmd/compare/515a6d0fd752...591d6c64ad7d
_______________________________________________
Pmd-commits mailing list
Pmd-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/pmd-commits
