Re: [pmwiki-devel] keep notify script from reporting multiple edits by same author

Mon, 05 Oct 2009 10:51:07 -0700

Sorry, I have to learn my way around here at PmWiki's...

Now I just learned that http://www.pmwiki.org/wiki/PITS/00676
was already dedicated to that feature request en it was closed by Pm.

I didn't understand Pm's hint though,
"It's also superceded by the new PmWiki.Notify capbility."

Is there anything else that I can do to promote the idea to have
multiple entries weeded out?

Frank



Dominique Faure wrote: 
On Mon, Oct 5, 2009 at 18:53, Frank Schweickert <[email protected]> wrote:
  
With every update of pmwiki I have to keep track of my modifications of
script/notify.php
So, maybe this suggestion can make it somehow into the official
distribution some day:

I purge my notification messages by deleting multiple edits of the same
author at the same page,
keeping only the last edit. My way is probably not the most efficient,
but it was a quick
fix that works for me... so if anybody would like to implement something
like this (maybe as an option)...?

I have introduced

##########
function dedup($var) {                             #fsmod: delete
earlier entries of same page and same author
  global $Author, $pagename;
  $aut = strpos ($var,urlencode(" {$Author}:"));
  $page = strpos ($var,urlencode(" $pagename "));
  return (!$aut || !$page);
  }
##########

and call it in function NotifyUpdate before $nnow = time(); last in
foreach($nlist as $n){...}

##########
   foreach($mailto as $m) {
     $notify[$m]=array_filter($notify[$m],"dedup");     #fsmod function
dedup above
     $notify[$m][] = $item;
##########


Best regards,
Frank
    

Hi,
IMHO, your issue really deserve a PITS entry, that we could vote on.

  


-- 
_______________________________________________________________________
Dr. Frank F. Schweickert
AMSTEL Institute, Faculty of Science, University of Amsterdam
Science Park 904, Amsterdam, Room C2-1.22
Postal address: Postbus 94224, 1090 GE Amsterdam
Phone: +31 20 525-8475 (secr. -5886)
http://www.science.uva.nl/amstel
http://www.natsim.net
_______________________________________________
pmwiki-devel mailing list
[email protected]
http://www.pmichaud.com/mailman/listinfo/pmwiki-devel

Reply via email to