Hi Pekka, I finished reformatting.
You can view the changes @
http://bazaar.launchpad.net/~bryan-w-bell/pocl/pocl/revision/703
I also fixed memory leaks in tests/runtime/test_clCreateProgramWithBinary.c
(hat tip to http://clang-analyzer.llvm.org/ for catching them).
Can you merge the changes in?
--Thanks
Bryan
On Fri, Apr 5, 2013 at 10:37 AM, Bryan Bell <[email protected]> wrote:
> Hi Pekka, I'll reformat the long lines.
>
> I agree, there should only be one platform visible when the test is
> executing.
> It's easy enough to remove the iteration over platforms.
>
>
> --Thanks!
> Bryan
>
>
> On Wed, Apr 3, 2013 at 3:24 AM, Pekka Jääskeläinen <
> [email protected]> wrote:
>
>> On 04/02/2013 12:55 PM, Bryan Bell wrote:
>>
>>> Comments?
>>>
>>
>> Some overlong lines (let's try to cut at 80 chars),
>> but otherwise LGTM.
>>
>> In the test it iterates over the platforms which
>> seems unnecessary as the tests should be able to
>> assume only one platform is visible when executed via
>> an ICD dispatcher that supports the OCL_ICD_VENDORS
>> override?
>>
>> But this seems to be the case also with the
>> previous runtime lib tests.
>>
>> --
>> --Pekka
>>
>
>
>
> --
> -- Regards
> Bryan
> Phone:530-355-5145
> http://www.google.com/profiles/Bryan.W.Bell
>
>
>
--
-- Regards
Bryan
Phone:530-355-5145
http://www.google.com/profiles/Bryan.W.Bell
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
pocl-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pocl-devel
