On 08/21/2013 07:56 PM, Peter Colberg wrote: > While I did not pursue the libcuda backend any further, I would like > to share a patch series which makes the scalarwave test work on the > GPU. The patches are not intended for inclusion in POCL, as they > contain specific hacks to make the test case work, and do not adhere > to the coding style yet. Nevertheless, the series might serve as a > starting point for someone else to pick up the development of a > libcuda backend.
If you got scalarwave to work on an NVIDIA GPU you have reached a major milestone! I would very much like to get your work in trunk so it lowers the bar to improve on it for everyone and to ensure that at least it doesn't bit rot out of tree. We can then add a testsuite-cuda.at that runs the tests (even if it's just the scalarwave) that work on the cuda driver if it's enabled in the build. I can then enable it by default for myself (I have an NVIDIA GPU card here) so it gets tested whenever I run the test suite and does not regress. The patches look good already, quickly looking. No major things stick to the eye. Mainly some overlong code lines at the style side. The pocl-specific address space IDs can be now converted to target-specific ones with the help of the TargetAddressSpace pass. See: http://pocl.sourceforge.net/docs/html/memory_management.html What other hacks do you refer to? Could you send a single patch against the trunk (or a merge request for a branch at LP) instead of the incremental patch set? I can then take a closer look, test it here and add the configure checks etc. -- Pekka ------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ pocl-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/pocl-devel
