Hi The PdfString changes look pretty good to me, having played with them for a while.
There are a few memory issues lurking in the unicode code. I haven't tracked them down yet. They're not currently causing test failures or crashes but definitely need to be fixed. I'll keep working on that but not now - I've already spent ages tracking down the PdfDoc->Unicode issue (below). I also hit what appears to be a bug in PdfDoc->Unicode conversion due to the use of a signed int index into the conversion array causing issues for char values > 127. Using `unsigned char' appears to me to be more correct, and does fix the problem. I'd like to make sure you're in agreement on this change, and I'm not doing something stupid. If I am, it'd be great if you could point out what or fix up the test case to be correct. The only thing that bothers me now is that there's no single method to determine how many characters there are in the string. One must check IsUnicode() and use GetUnicodeLength() instead of GetLength(). It also doesn't appear to be safe to assume that: str.GetLength() == str.ToUnicode().GetUnicodeLength() (where !str.IsUnicode()) ... at least at a superficial look. -- Craig Ringer ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Podofo-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/podofo-users
