Chuck Messenger wrote:
> I'm doing some testing with PoDoFo. One little issue I came across is that
> the
> PODOFO_RAISE_ERROR() does:
>
> throw PdfError(...)
>
> i.e. without the PoDoFo namespace. This means that in order to use the
> macro, I
> must have
>
> using namespace PoDoFo;
>
>
Good point. You actually only need to use the statement:
using PoDoFo::PdfError;
... but you should not need to do that.
> In general, I don't like to do this -- even, generally, for my own libraries,
> but particularly for libraries I'm not familiar with.
>
> A suggestion: add the namespace to the _RAISE_ macros, e.g.
>
> throw PoDoFo::PdfError(...)
>
> Similarly, in the following macro, add PoDoFo namespace to
> ePdfError_InternalLogic:
>
> #define PODOFO_RAISE_LOGIC_IF( x, y ) { if (x) throw PoDoFo::PdfError(
> PoDoFo::ePdfError_InternalLogic,
> __FILE__, __LINE__, y ); };
>
>
That shouldn't be seeing use outside PoDoFo's namespaces anyway, but
should still be updated.
--
Craig Ringer
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Podofo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/podofo-users
