Pierre Marchand wrote: > Wow, i’ve wrote something with almost similar design this afternoon! Although > i’ve began by reimplementing the actual code in a separate class first, what > led me to deeply clean up pdftranslator class. I guess there aren’t too much > options then and i will happily mix your code with mine.
Glad to hear it. I guess I'll let you carry on from here, then, though if you want to check your work into a branch in svn I might be able to help you out with it (at least doing things like adding a FindLua.cmake module). > As the only _big_ difference with what I write is that "addrec" would > be "PushRecord" ... which I needed to rename anyway ;-) > even your PLAN files should easily convert. Oh, there is > something different, I would not provide other set/get method than > setNumber/getNumber. They weren't really needed, I just included them in case they proved useful in the future. > Note: If at first I just wrote 2 classes ReadPlan_legacy and ReadPlan_Lua, I > know think to have a base class ReadPlan and implement something > like "strategy" pattern to pickup the right descendant depending of user > input or automatic detection. What do you think? Right now I would not bother. If you want to support both plan formats it can easily be done by a command line switch, so a different plan reader is selected by the user as appropriate and the resulting Plan object is passed to the podofoimpose core without it caring what created it. Autodetecting the plan format doesn't really seem necessary, and it might not be that easy either. -- Craig Ringer ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Podofo-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/podofo-users
