I just noticed that I seem to not have commited this patch. Thanks for this additions, I commited them now!
best regards,
Dom
Am Samstag, 15. November 2008 schrieb Jonathan Verner:
> Hi Dominik.
>
> Thank you for applying the patch. The approach to have a separate
> method to set the quadpoints is definitely better, my bad. Sorry to
> overwhelm you, but attached please find another patch, which has
> two objectives:
>
> 1) fixes a typo in the SetQuadPoints method
>
> 2) Adds the possibility to set/get the color of the annotations.
> Without this, the hilight annotations are transparent (since
> the C key is missing from the dictionary), so are not of much
> use :-)
>
> Regarding the refactoring, I can also try to think about it, but I
> don't have much experience and even less time :-(
>
> Best,
>
> Jonathan
>
> P.S. The documentation for the quadpoints follows the pdf spec.,
> but seems to be at odds with how it actually works in Acrobat
> Reader. I seem to get the best results if the order of the points
> is TopLeft TopRright BottomLeft BottomRight. However there might
> be a bug somewhere in my code, so I'll try to do some more testing
> to confirm where the problem is.
>
> Dne Saturday 15 November 2008 16:46:31 Dominik Seichter napsal(a):
> > Hi Jonathan,
> >
> > Thanks for your patch. I commited the GetQuadPoints method you
> > added. Instead of adding the quadpoints argument to the
> > CreateAnnotation method, I added a method SetQuadPoints. This
> > should work for you as well and is more consistent with all the
> > currently available annotations.
> >
> > The annotation API is not very good and needs some refactoring.
> > So the set method is no good solution either, but I prefer it
> > more to adding all possible arguments to the CreateAnnoations
> > method. This might be a matter of taste. Well, maybe I'l lfind
> > sometimes a minute to think of a better approach. Patches are
> > welcome of course :)
> >
> > best regards
> > Dom
--
**********************************************************************
Dominik Seichter - [EMAIL PROTECTED]
KRename - http://www.krename.net - Powerful batch renamer for KDE
KBarcode - http://www.kbarcode.net - Barcode and label printing
PoDoFo - http://podofo.sf.net - PDF generation and parsing library
SchafKopf - http://schafkopf.berlios.de - Schafkopf, a card game, for KDE
Alan - http://alan.sf.net - A Turing Machine in Java
**********************************************************************
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________ Podofo-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/podofo-users
