Hi,
I just downloaded version 1077.
The PdfCompilerCompat.h should be adjusted:
For __BORLANDC__ the PODOFO_FUNCTION__ define fails, because __LINE__ is not
a string, it's an numeric literal.
The next defines do work, (found it on the internet
http://gcc.gnu.org/onlinedocs/gcc-3.2.3/cpp/Stringification.html#Stringification
):
#define PODOFO__FUNCTION__XSTR(x) PODOFO__FUNCTION__STR(x)
#define PODOFO__FUNCTION__STR(x) #x
#define PODOFO__FUNCTION__ (__FILE__ ":" PODOFO__FUNCTION__XSTR(__LINE__))
The issue with the HAVE_BOOLEAN in PdfFiltersPrivate.h and PdfImage.cpp:
I would suggest to make an include file PdfExternalImageLibs.h. This file
should include libjpeg, libtiff and maybe in the future other libs for
loading images. In this file all problems concerning external files when
using libjpeg and libtiff can be handled.
Strangely enough in PdfFiltersPrivate.h first is the libjpeg included and
second the libtiff.h
In PdfImage.cpp it's the other way around, first libtiff and then libjpeg
Regards,
Mirco
2009/7/20 Craig Ringer <[email protected]>
> On Mon, 2009-07-20 at 14:21 +0200, Mirco Babin wrote:
>
> > - Extra includes for Borland:
> > # include <math.h>
> > # include <stdio.h>
> > # include <time.h>
> > # include <string.h>
>
> Hmm, ok. Well, ISO C++ is only from 1997, right? ...
>
> Handled for the Borland compiler in PdfCompilerCompat.h . Work OK?
>
> > - # define PODOFO__FUNCTION__ __FUNC__
>
> Does the current definition in PdfCompilerCompat.h do the job? As of svn
> revision 1077 a few minutes before I sent this message.
>
> > - #if HAVE_WINSOCK_H must be #if HAVE_WINSOCK2_H (type error)
>
> My bad. Whoops. Fixed in svn.
>
> > - For WINSOCK2.H, after then #undef GetObject also #undef DrawText
> > (otherwise PdfPainter.cpp will not compile)
>
> Fixed in svn.
>
> > 2) The PdfField.cpp needs an extra pair of ( ) around "bChecked ?
> > PdfName("Yes") : PdfName("Off")" in function SetChecked:
> > C:\a\open\PoDoFo\podofo\src\PdfField.cpp:
>
> Fixed in svn.
>
> > 3) Inclusion of the jpeglib.h in PdfFiltersPrivate.h: #define
> > HAVE_BOOLEAN is needed
>
> Will fix shortly. I want to see what the nicest way to do this is.
>
> > 5) There is a type error in PdfImage.cpp (line 179), "strncasecmp"
> > should be "PoDoFo::compat::strncasecmp"
>
> My bad. Fixed in svn.
>
> --
> Craig Ringer
>
>
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Podofo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/podofo-users
