I haven't had a chance to test the patch yet, but I will shortly. You're right about the lack of recursion of the pthread mutexes; I didn't think about that. I believe the Windows critical sections are recursive by default so that shouldn't be an issue. One thing I did want to mention is that it would be a good idea to call pthread_mutexattr_init with the mutexattr before setting any attributes because its values should be undefined how you're using it. Calling the init will use all the default attributes for the mutex (and then you can override the type for the reentrant mutex).
- Mike Slegeir Craig Ringer wrote: > Initial patch attached. > > Limited testing so far: > - No win32 test build, known issues in win32 code > - No test w threading disabled, known issues w/o threading > - Only basic pthread testing > > Cmake isn't yet conditionally compiling the .cpp parts yet either, but > that'll only take me a sec. > > Expect a commit with the finished and tested changes later tonight > (+0800 time). > > -- > Craig Ringer > ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Podofo-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/podofo-users
