Hi Jörg,

Thanks for your patch. I commited it to SVN. Work like this is really helpful.

> src/PdfFontMetrics.cpp:1132: warning: comparison is always true due to
>  limited range of data type 
I removed the check. It is simply useless.

>  src/PdfParser.cpp:693: warning: format '%10lld'
>  expects type 'long long int*', but argument 3 has type 'PoDoFo::pdf_long*'
Well, I have to think about this :)

Best regards,
        Dom


Am Montag 23 November 2009 schrieb Richter, Jörg:
> Hi,
> 
> I am compiling PoDoFo with following flags and get some warnings.
> 
> -Wall -Wextra -Wwrite-strings -Wformat-security -Wno-unused-parameter
>  -Wno-sign-compare -Wno-non-virtual-dtor -Wno-format-y2k
>  -Wno-ctor-dtor-privacy -Woverloaded-virtual -Wcast-qual -Wno-parentheses
>  -Wno-missing-field-initializers -Wunused-macros
> 
> Find attached a patch to fix all but two.  Most of them were unused macros
>  or functions.
> 
> Remainings warnings are:
> 
> src/PdfFontMetrics.cpp:1132: warning: comparison is always true due to
>  limited range of data type 


>  src/PdfParser.cpp:693: warning: format '%10lld'
>  expects type 'long long int*', but argument 3 has type 'PoDoFo::pdf_long*'
> 
> There is more than one way to fix them.  So I didn't.
> 
> And another minor nit: src/PdfCompilerCompatPrivate.h seems to be the only
>  file with CRLF line terminators.
> 
> 
>    Jörg
> 


-- 
**********************************************************************
Dominik Seichter - domseich...@web.de
KRename  - http://www.krename.net  - Powerful batch renamer for KDE
KBarcode - http://www.kbarcode.net - Barcode and label printing
PoDoFo - http://podofo.sf.net - PDF generation and parsing library
SchafKopf - http://schafkopf.berlios.de - Schafkopf, a card game,  for KDE
Alan - http://alan.sf.net - A Turing Machine in Java
**********************************************************************

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to