Hi Jonathan, Thanks for your contribution! Very nice addition.
I suggest that you make the getters inline. As well, I would prefer if the
getters would throw an exception if the required information is not available.
Could you please update your patch? I will commit it, as soon as I get the
updated version.
Best regards,
Dom
Am Freitag 14 Mai 2010 schrieb Jonathan Verner:
> Hello,
>
> I am working on a program which uses PoDoFo to save/read
> annotations to/from pdf files. When I am reading a Link Annotation and
> get its Destination, I need to be able to actually find the parameters of
> the destination. The PdfDestination class has a method to determine
> the Page but no method to e.g. determine the fit rectangle. Attached
> is a patch which adds methods that allow to retrieve this additional
> information.
>
> I have some questions:
>
> First Is there another way to do this which I missed and which would
> make this patch superfluous?
>
> Regarding the patch:
>
> 1) Should the get methods be made inline?
>
> 2) Since the information available depends on the Destination Type,
> should the get methods check whether the destination type
> supports the information to be got or should this be left up
> to the user? If it should check, then in case the information is
> unavailable, should it return a "void" value or should it throw
> an error.
>
>
>
> Have a nice day,
>
> Jonathan Verner
>
--
**********************************************************************
Dominik Seichter - [email protected]
KRename - http://www.krename.net - Powerful batch renamer for KDE
KBarcode - http://www.kbarcode.net - Barcode and label printing
PoDoFo - http://podofo.sf.net - PDF generation and parsing library
SchafKopf - http://schafkopf.berlios.de - Schafkopf, a card game, for KDE
Alan - http://alan.sf.net - A Turing Machine in Java
**********************************************************************
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------
_______________________________________________ Podofo-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/podofo-users
