On Wed, 2014-06-11 at 22:28 +0200, Petr Pytelka wrote:
> - int GetChildCount( const PdfObject* pNode ) const;
> + static int GetChildCount( const PdfObject* pNode );
>
> Reasons to change signature of the method:
> 1. GetChildCount does not need any member variables from PdfPagesTree
Hi,
so it is kind-of a utility function, which can explain why it's
private.
> 2. Method is called from the constructor of PdfPagesTree
That's not problem at all, it can be done.
> 3. Method is private in PdfPagesTree and was used only at one place.
> Changing signature cannot break any APIs or applications.
Maybe will not break API, still will change it. None of the 3 points
is a strong argument to make the function static, at least from my
point of view. If anyone else can rise his/her voice regarding this
change, then I'll appreciate it.
Otherwise the patch looks fine.
Bye,
zyx
--
http://www.litePDF.cz i...@litepdf.cz
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
