On 24.03.2015 16:54, zyx wrote: > On Sat, 2015-03-21 at 10:59 +0200, Elan Ruusamäe wrote: >> as tickets creation is disabled in sourceforge page, sending patch to >> mailing list > Hi, > there is no patch attached here. (I know you pasted the link, but the > link can get obsolete soon). and so can the codebase the patch can be applied to be obsolete soon, but i hope it doesn't go that far :)
anyway, here's permanlink for the patch https://github.com/pld-linux/podofo/blob/auto/th/podofo-0.9.3-2/libdir.patch >> the attached patch adds support for controlling lib dir with >> standard LIB_SUFFIX variable. > Do you have any pointers where is stated that the LIB_SUFFIX is the > standard variable for this purpose, please? Searching with Google gave > me nothing trustworthy, even getting some people prefer LIB_SUFFIX > while other prefer LIBDIR_SUFFIX, which makes this a mess. Not that > it's against your change, I'm only chasing for some details. we use it in our distribution (pld-linux) where most of the projects respect -DLIB_SUFFIX, so i boldly assumed it's some kind of standard :) as far i know, then some things are convention rather than standard, and some variables use relative paths while others use absolute paths -- it's very messy! for example our %cmake expands to (on a x86-64 system): /usr/bin/cmake \ -DCMAKE_VERBOSE_MAKEFILE=ON \ -DCMAKE_BUILD_TYPE=PLD \ -DCMAKE_INSTALL_BINDIR:PATH=/usr/bin \ -DCMAKE_INSTALL_SBINDIR:PATH=/usr/sbin \ -DCMAKE_INSTALL_LIBEXECDIR:PATH=/usr/lib64 \ -DCMAKE_INSTALL_SYSCONFDIR:PATH=/etc \ -DCMAKE_INSTALL_SHAREDSTATEDIRPATH:PATH=/var/lib \ -DCMAKE_INSTALL_LOCALSTATEDIRPATH:PATH=/var \ -DCMAKE_INSTALL_LIBDIR:PATH=/usr/lib64 \ -DCMAKE_INSTALL_INCLUDEDIR:PATH=/usr/include \ -DCMAKE_INSTALL_OLDINCLUDEDIR:PATH=/usr/include \ -DCMAKE_INSTALL_DATAROOTDIR:PATH=/usr/share \ -DCMAKE_INSTALL_DATADIR:PATH=/usr/share \ -DCMAKE_INSTALL_INFODIR:PATH=/usr/share/info \ -DCMAKE_INSTALL_LOCALEDIR:PATH=/usr/share/locale \ -DCMAKE_INSTALL_MANDIR:PATH=/usr/share/man \ -DCMAKE_INSTALL_DOCDIR:PATH=%{_docdir} \ -DCMAKE_INSTALL_PREFIX:PATH=/usr \ -DSYSCONF_INSTALL_DIR:PATH=/etc \ -DCMAKE_CXX_FLAGS_PLD="${CXXFLAGS:--O2 -fwrapv -pipe -Wformat -Werror=format-security -gdwarf-4 -fno-debug-types-section -fvar-tracking-assignments -g2 -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fPIC -march=x86-64 -gdwarf-4 -fno-debug-types-section -fvar-tracking-assignments -g2 -DNDEBUG -DQT_NO_DEBUG}" \ -DCMAKE_C_FLAGS_PLD="${CFLAGS:--O2 -fwrapv -pipe -Wformat -Werror=format-security -gdwarf-4 -fno-debug-types-section -fvar-tracking-assignments -g2 -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fPIC -march=x86-64 -gdwarf-4 -fno-debug-types-section -fvar-tracking-assignments -g2 -DNDEBUG -DQT_NO_DEBUG}" \ -DCMAKE_Fortran_FLAGS_PLD="${CFLAGS:--O2 -fwrapv -pipe -Wformat -Werror=format-security -gdwarf-4 -fno-debug-types-section -fvar-tracking-assignments -g2 -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fPIC -march=x86-64 -gdwarf-4 -fno-debug-types-section -fvar-tracking-assignments -g2 -DNDEBUG -DQT_NO_DEBUG}" \ -DCMAKE_EXE_LINKER_FLAGS_PLD="${LDFLAGS:--Wl,--as-needed -Wl,--no-copy-dt-needed-entries -Wl,-z,relro -Wl,-z,combreloc }" \ -DCMAKE_SHARED_LINKER_FLAGS_PLD="${LDFLAGS:--Wl,--as-needed -Wl,--no-copy-dt-needed-entries -Wl,-z,relro -Wl,-z,combreloc }" \ -DCMAKE_MODULE_LINKER_FLAGS_PLD="${LDFLAGS:--Wl,--as-needed -Wl,--no-copy-dt-needed-entries -Wl,-z,relro -Wl,-z,combreloc }" \ %if "lib64" == "lib64" -DLIB_SUFFIX=64 \ %endif %if "lib64" == "libx32" -DLIB_SUFFIX=x32 \ %endif -DBUILD_SHARED_LIBS:BOOL=ON \ > Thanks and bye, > zyx > -- glen ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
