On Wed, 2015-09-30 at 23:59 +0000, Matthew Brincke wrote:
> -    snprintf( szZone, ZONE_STRING_SIZE, "%+03d", -_timezone/3600 );
> ...
> +    snprintf( szZone, ZONE_STRING_SIZE, "%+03ld", time_off/3600 );

        Hi,
just briefly looking on the patch, the format specifiers are always a
pita. The %ld is not correct for 32bit compilation, also because the
time_t size can differ between architectures. As the actual value is
expected to not be too large, I'd prefer to use %d (without 'l') and
cast the argument to int. Note of the format specifiers in
src/base/PdfCompilerCompat.h too.
        Bye,
        zyx

P.S.: I omitted  the "+03" in the format specifier for readiness

-- 
http://www.litePDF.cz                                 i...@litepdf.cz



------------------------------------------------------------------------------
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to