Hi zyx,
the patch attached to this e-mail is only meant as a
workaround for a doxygen issue, please look at the
current documentation for PdfString::ToUnicode(),
to tidy that up (hide the documentation for the
deactivated methods). Therefore no code (meaning)
change is desired (and I hope you agree with me that
the syntactic change is so minimal as to make compile-
testing"thus unnecessary"). I have tested the change
with doxygen, it works (hides what's unavailable).
So could you please accept this documentation patch,
or otherwise tell me why you don't accept it as such one?
Best regards, mabri
P.S. Pardon, the FAQ patch isn't current, I've overlooked typos ;-(.
----- Original Message -----
From: zyx <z...@litepdf.cz>
To: podofo-users@lists.sourceforge.net
CC:
Sent: 7:30 Wednesday, 4 November 2015
Subject: Re: [Podofo-users] tidying up PdfString documentation around
deactivated lines before/affecting ToUnicode()
On Tue, 2015-11-03 at 23:20 +0000, Matthew Brincke wrote:
> I have attached a patch as per the subject to this e-mail.
Hi,
I wouldn't do this change. Adding TODO is something I'd not accept.
Furthermore, the change is simply void, thus unnecessary. Once the
whole thing will work it'll make sense to be done together, but this
part alone doesn't. I'm sorry.
Bye,
zyx
--
http://www.litePDF.cz i...@litepdf.cz
------------------------------------------------------------------------------
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
Index: src/base/PdfString.h
===================================================================
--- src/base/PdfString.h (revision 1687)
+++ src/base/PdfString.h (working copy)
@@ -331,6 +331,7 @@
*/
bool operator!=(const PdfString& rhs) const { return !operator==(rhs); }
+#if 0 // this is a workaround for doxygen including the following otherwise
/** Converts this string to a hex encoded string.
*
* If IsHex returns true, a copy of this string is returned
@@ -341,7 +342,7 @@
*
* \see IsHex
*/
- //PdfString HexEncode() const;
+ PdfString HexEncode() const;
/** Converts this string to a ascii string (not hex encoded)
*
@@ -353,7 +354,8 @@
*
* \see IsHex
*/
- //PdfString HexDecode() const;
+ PdfString HexDecode() const;
+#endif
/** Converts this string to a unicode string
*
------------------------------------------------------------------------------
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
