On Mon, 2015-11-30 at 20:17 +0100, julian.rehb...@de.gbs.com wrote:
> I additional created a patch file based on trunk revision 1697. 

        Hi,
weird, I do not have the original message, it might be a long time, I
guess.

Anyway, thanks for the patch, but I have couple queries:

a) do not use backslashes in #include paths, that's not good (there
belongs a forward slash instead); also, the path specification is not
needed in the PdfInputStream.cpp, because you are already in the base/
folder.

b) the PdfFileSpec does the same thing twice (your added code), a new
private method adding necessary keys into the 'params' would make
things simpler. I imagine something like:
   void AddDateParams(PdfDictionary &params,
                      const PdfDate &creation_date,
                      const PdfDate &mod_date);

c) what if the caller would like to attach data blobs, not actual
files? It would be nice to be able to define these creation and
modification dates for those cases too (you might be able to use the
method from the b) again here). Thus the PDF/A-3 specification will be
still satisfied.

Does it make sense?
        Bye,
        zyx

-- 
http://www.litePDF.cz                                 i...@litepdf.cz



------------------------------------------------------------------------------
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to