Hi,
I read your other e-mail about a build error, AFAIK I have corrected it with
the patch attached to this e-mail to be applied in addition to the both parts.
I herewith ask all committers of the PoDoFo project to reconsider zyx' decision
to refrain from commiting either of the patches this thread is about, for the
following reasons:
- it is in the FAQ that PoDoFo's API isn't stable because its development is
not yet at a point where that (a stable API) is practical
- a code or even API freeze (e. g. for an upcoming release) has not been
announced (by those having the power to do so in this project, of course)
- the project does not seem so active that an API change at this time would
disrupt other developers in it
- especially in the light that there are probably usable means of automating
changes in API in code using the library (I can assume several of you have
more experience in modern software development, also with automatic
assistance I hope, than I have, right?)
- I'd like very much to know whether there are any reverse dependencies
who have decided to rely on an unreleased revision (to work with them)
- zyx maintains a product based on PoDoFo himself so I suspect why he acts like
this
Best regards and I hope for an agreement in February,
mabri
--------------------------------------------
zyx <z...@litepdf.cz> wrote on Fr, 15.01.2016:
Subject: Re: [Podofo-users] Public API method names typo fixes &
clarifications (now part 2)
To: podofo-users@lists.sourceforge.net
Date: Friday, 15 January, 2016 18:22
On Wed, 2015-12-23 at 22:46 +0000, Matthew Brincke wrote:
> attached to this e-mail is the second part of the API
> changes
Hi,
any API change is a pita. While it can be nice to have properly named
functions, it's a pita to update all other software using the library
for the new API, especially when it's done only for "cosmetic"
reasons.
I'm not going to commit this, I left it to the maintainers.
Bye,
zyx
--
http://www.litePDF.cz i...@litepdf.cz
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
Index: /media/sda10/matthias/Projekte/podofo-code/podofo/trunk/test/unit/EncryptTest.cpp
===================================================================
--- /media/sda10/matthias/Projekte/podofo-code/podofo/trunk/test/unit/EncryptTest.cpp (revision 1699)
+++ /media/sda10/matthias/Projekte/podofo-code/podofo/trunk/test/unit/EncryptTest.cpp (working copy)
@@ -203,7 +203,7 @@
try {
pEncrypt->Encrypt( reinterpret_cast<unsigned char*>(m_pEncBuffer), m_lLen, pEncryptedBuffer, nOutputLen );
} catch (PdfError &e) {
- CPPUNIT_FAIL(e.ErrorMessage(e.GetError()));
+ CPPUNIT_FAIL(e.GetErrorMessage(e.GetError()));
}
// Decrypt buffer
@@ -210,7 +210,7 @@
try {
pEncrypt->Decrypt( pEncryptedBuffer, nOutputLen, pDecryptedBuffer, m_lLen );
} catch (PdfError &e) {
- CPPUNIT_FAIL(e.ErrorMessage(e.GetError()));
+ CPPUNIT_FAIL(e.GetErrorMessage(e.GetError()));
}
CPPUNIT_ASSERT_EQUAL_MESSAGE( "compare encrypted and decrypted buffers",
@@ -378,7 +378,7 @@
pStream->Write( pBuffer2, strlen( pBuffer2 ) );
pStream->Close();
- printf("Result: %i \n", memcmp( pEncBuffer, mem.TakeBuffer(), lLen ) );
+ printf("Result: %i \n", memcmp( pEncBuffer, mem.GiveBuffer(), lLen ) );
enc.Encrypt( reinterpret_cast<unsigned char*>(pEncBuffer), lLen );
Index: /media/sda10/matthias/Projekte/podofo-code/podofo/trunk/test/unit/cppunitextensions.h
===================================================================
--- /media/sda10/matthias/Projekte/podofo-code/podofo/trunk/test/unit/cppunitextensions.h (revision 1699)
+++ /media/sda10/matthias/Projekte/podofo-code/podofo/trunk/test/unit/cppunitextensions.h (working copy)
@@ -68,7 +68,7 @@
else \
{ \
cpputMsg_.addDetail( "Error type mismatch. Actual: " #errorType ); \
- cpputMsg_.addDetail( std::string("What() : ") + e.ErrorName(e.GetError()) ); \
+ cpputMsg_.addDetail( std::string("What() : ") + e.GetErrorName(e.GetError()) ); \
} \
} catch ( const std::exception &e) { \
cpputMsg_.addDetail( "Actual : " + \
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
