On Thu, 2016-04-21 at 22:41 +0000, Matthew Brincke wrote:
> I'd like to submit a patch for that (-Wformat= warnings),
> but I think I should ask you about the course to take:
> correct the format strings (I'd omit those concerning
> pdf_long values, that's another matter, I think, because
> AFAIK pdf_long is deprecated/should be removed anyway,
> in a separate commit, of course) or get rid of printf()
> and sscanf() at least in these cases by replacing them
> with the correct iostream (cout for printf()) operations?
Hi,
I admit that I code more in C these days (years) than in C++/STL, thus
for me fixing the printf/sscanf formats makes more sense, also because
the PoDoFo needs more control on the output format, like once you need
to write a double with 3 digit precision, another time with 8 digit
precision, which is pretty simple to do in the printf format string.
It seems I've currently turned off printf format warnings, because I do
not see any of them. If you want to address any, then the best if you
address all. The PdfCompilerCompat.h contains defines for this purpose,
one of them being PDF_FORMAT_INT64, to cover the issue cross-platform.
If there are needed more, then they should be added here. Similar
with PODOFO_LL_LITERAL define.
If you'd be unsure with any place, then just ask with a pointer to it.
Bye,
zyx
--
http://www.litePDF.cz i...@litepdf.cz
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
