On Tue, 2016-04-26 at 21:27 +0000, Matthew Brincke wrote:
> Hi PoDoFo developers,
>
> I have found a problem which causes libpng not to be
> found even if it's available: the module FindPNG.cmake
> of the system cmake (I have version 3.0.2 here) seems
> to include the system FindZLIB.cmake only, even with
> CMAKE_MODULE_PATH set and CMP0017 policy set to NEW
> (as is already done in trunk/CMakeLists.txt). So to
> make cmake use PoDoFo's FindZLIB.cmake (as the system's
> one seems unsuitable for GNU/Linux) I have copied the
> system's FindPNG.cmake to cmake/modules in PoDoFo, made
> the changes which are attached to this e-mail as a patch,
> and build-tested it: it works now.
Hi,
I'm afraid I do not have yours FindPNG.cmake file, thus the diff is not
relevant in general. Better to consolidate all the changes, not only
changes of some random file of a random system.
> make the necessary license notice
> completions as specified in cmake's FindPNG.cmake (sorry,
> IMHO that's your responsibility ;-) )
Hmm, well, I do not think so, provide a complete proposal, please.
By the way:
$ cmake --version
cmake version 3.4.1
and I didn't notice any issue with the PNG library finding.
The podofo_config.h says:
#define PODOFO_HAVE_PNG_LIB
and the CMakeCache.txt says:
//Path to a library.
PNG_LIBRARY_DEBUG:FILEPATH=PNG_LIBRARY_DEBUG-NOTFOUND
//Path to a library.
PNG_LIBRARY_RELEASE:FILEPATH=/usr/lib64/libpng.so
//Path to a file.
PNG_PNG_INCLUDE_DIR:PATH=/usr/include
Thus I'd hesitate to commit a change for an old cmake, when the newer
doesn't have any issue. (Or I didn't notice the issue here.)
Bye,
zyx
--
http://www.litePDF.cz i...@litepdf.cz
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
