Hi all,
because I was annoyed that grep classified PoDoFo source
code files as binary, I translated some comments in them
which solved this problem (except for VariantTest and
ObjectParserTest, they have non-ASCII in test data, I left
them as-is also because they are outside the library source).
I've attached a patch with these changes, could you please
review and if you are PoDoFo committer, apply and commit this
to the public repository (please use the subject I've written
as part of the commit message).
Best regards, mabri
Index: src/base/PdfParser.cpp
===================================================================
--- src/base/PdfParser.cpp (revision 1721)
+++ src/base/PdfParser.cpp (working copy)
@@ -79,7 +79,7 @@
}
#ifdef _WIN32
-#if defined(_MSC_VER) && _MSC_VER <= 1200 // nicht für Visualstudio 6
+#if defined(_MSC_VER) && _MSC_VER <= 1200 // not for MS Visual Studio 6
#else
PdfParser::PdfParser( PdfVecObjects* pVecObjects, const wchar_t* pszFilename, bool bLoadOnDemand )
: PdfTokenizer(), m_vecObjects( pVecObjects )
@@ -158,7 +158,7 @@
}
#ifdef _WIN32
-#if defined(_MSC_VER) && _MSC_VER <= 1200 // nicht für Visualstudio 6
+#if defined(_MSC_VER) && _MSC_VER <= 1200 // not for MS Visual Studio 6
#else
void PdfParser::ParseFile( const wchar_t* pszFilename, bool bLoadOnDemand )
{
Index: src/base/PdfParser.h
===================================================================
--- src/base/PdfParser.h (revision 1721)
+++ src/base/PdfParser.h (working copy)
@@ -101,7 +101,7 @@
PdfParser( PdfVecObjects* pVecObjects, const char* pszFilename, bool bLoadOnDemand = true );
#ifdef _WIN32
-#if defined(_MSC_VER) && _MSC_VER <= 1200 // nicht für Visualstudio 6
+#if defined(_MSC_VER) && _MSC_VER <= 1200 // not for MS Visual Studio 6
#else
/** Create a new PdfParser object and open a PDF file and parse
* it into memory.
Index: src/base/PdfString.cpp
===================================================================
--- src/base/PdfString.cpp (revision 1721)
+++ src/base/PdfString.cpp (working copy)
@@ -109,7 +109,7 @@
Init( pszString, strlen( pszString ) );
}
-#if defined(_MSC_VER) && _MSC_VER <= 1200 // nicht für Visualstudio 6
+#if defined(_MSC_VER) && _MSC_VER <= 1200 // not for MS Visual Studio 6
#else
PdfString::PdfString( const wchar_t* pszString, pdf_long lLen )
{
Index: src/base/PdfString.h
===================================================================
--- src/base/PdfString.h (revision 1721)
+++ src/base/PdfString.h (working copy)
@@ -109,7 +109,7 @@
*
* \param pszString the string to copy
*/
-#if defined(_MSC_VER) && _MSC_VER <= 1200 // nicht für Visualstudio 6
+#if defined(_MSC_VER) && _MSC_VER <= 1200 // not for MS Visual Studio 6
#else
PdfString( const wchar_t* pszString, pdf_long lLen = -1 );
#endif
Index: src/base/PdfWriter.cpp
===================================================================
--- src/base/PdfWriter.cpp (revision 1721)
+++ src/base/PdfWriter.cpp (working copy)
@@ -45,7 +45,6 @@
#include "PdfXRefStream.h"
#include "PdfDefinesPrivate.h"
-//#define PDF_MAGIC "%âãÏÓ\n" //"%\0x25\0xe2\0xe3\0xcf\0xd3\0x0d"
#define PDF_MAGIC "\xe2\xe3\xcf\xd3\n"
// 10 spaces
#define LINEARIZATION_PADDING " "
Index: src/doc/PdfFontMetrics.cpp
===================================================================
--- src/doc/PdfFontMetrics.cpp (revision 1721)
+++ src/doc/PdfFontMetrics.cpp (working copy)
@@ -985,7 +985,7 @@
}
#ifndef _WCHAR_T_DEFINED
-#if defined(_MSC_VER) && _MSC_VER <= 1200 // nicht für Visualstudio 6
+#if defined(_MSC_VER) && _MSC_VER <= 1200 // not for MS Visual Studio 6
#else
double PdfFontMetrics::StringWidth( const wchar_t* pszText, unsigned int nLength ) const
{
Index: src/doc/PdfFontMetrics.h
===================================================================
--- src/doc/PdfFontMetrics.h (revision 1721)
+++ src/doc/PdfFontMetrics.h (working copy)
@@ -110,7 +110,7 @@
double StringWidth( const pdf_utf16be* pszText, unsigned int nLength = 0 ) const;
#ifndef _WCHAR_T_DEFINED
-#if defined(_MSC_VER) && _MSC_VER <= 1200 // nicht für Visualstudio 6
+#if defined(_MSC_VER) && _MSC_VER <= 1200 // not for MS Visual Studio 6
#else
/** Retrieve the width of a given text string in PDF units when
* drawn with the current font
@@ -139,7 +139,7 @@
inline unsigned long StringWidthMM( const pdf_utf16be* pszText, unsigned int nLength = 0 ) const;
#ifndef _WCHAR_T_DEFINED
-#if defined(_MSC_VER) && _MSC_VER <= 1200 // nicht für Visualstudio 6
+#if defined(_MSC_VER) && _MSC_VER <= 1200 // not for MS Visual Studio 6
#else
/** Retrieve the width of a given text string in 1/1000th mm when
* drawn with the current font
@@ -433,7 +433,7 @@
//
// -----------------------------------------------------
#ifndef _WCHAR_T_DEFINED
-#if defined(_MSC_VER) && _MSC_VER <= 1200 // nicht für Visualstudio 6
+#if defined(_MSC_VER) && _MSC_VER <= 1200 // not for MS Visual Studio 6
#else
unsigned long PdfFontMetrics::StringWidthMM( const wchar_t* pszText, unsigned int nLength ) const
{
Index: src/doc/PdfMemDocument.cpp
===================================================================
--- src/doc/PdfMemDocument.cpp (revision 1721)
+++ src/doc/PdfMemDocument.cpp (working copy)
@@ -89,7 +89,7 @@
}
#ifdef _WIN32
-#if defined(_MSC_VER) && _MSC_VER <= 1200 // nicht für Visualstudio 6
+#if defined(_MSC_VER) && _MSC_VER <= 1200 // not for MS Visual Studio 6
#else
PdfMemDocument::PdfMemDocument( const wchar_t* pszFilename )
: PdfDocument(), m_pEncrypt( NULL ), m_pParser( NULL )
@@ -194,7 +194,7 @@
}
#ifdef _WIN32
-#if defined(_MSC_VER) && _MSC_VER <= 1200 // nicht für Visualstudio 6
+#if defined(_MSC_VER) && _MSC_VER <= 1200 // not for MS Visual Studio 6
#else
void PdfMemDocument::Load( const wchar_t* pszFilename )
{
Index: src/doc/PdfMemDocument.h
===================================================================
--- src/doc/PdfMemDocument.h (revision 1721)
+++ src/doc/PdfMemDocument.h (working copy)
@@ -100,7 +100,7 @@
PdfMemDocument( const char* pszFilename );
#ifdef _WIN32
-#if defined(_MSC_VER) && _MSC_VER <= 1200 // nicht für Visualstudio 6
+#if defined(_MSC_VER) && _MSC_VER <= 1200 // not for MS Visual Studio 6
#else
/** Construct a PdfMemDocument from an existing PDF (on disk)
* \param pszFilename filename of the file which is going to be parsed/opened
@@ -136,7 +136,7 @@
void Load( const char* pszFilename );
#ifdef _WIN32
-#if defined(_MSC_VER) && _MSC_VER <= 1200 // nicht für Visualstudio 6
+#if defined(_MSC_VER) && _MSC_VER <= 1200 // not for MS Visual Studio 6
#else
/** Load a PdfMemDocument from a file
*
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
