Hi all,
I don't think the patch should be applied as-is, because it has a wrong indentation length (AFAICS 7 spaces, but the CodingStyle says 4 spaces), very long lines and I think the two changes (the former one and the new) should be committed separately, as they're two distinct logical changes IIRC. Best regards, mabri ________________________________ From: Jaseem Ali K T <jaseemal...@hcl.com> To: "podofo-users@lists.sourceforge.net" <podofo-users@lists.sourceforge.net> Sent: Wednesday, 29 June 2016, 18:22 UTC Subject: [Podofo-users] MultiLineText Improvements Hi All I have made some more improvements to DrawMultiLineText() function of PdfPainter class. Current behavior is roughly as follows: We will calculate the top of the topmost each line based on vertical alignment. We will calculate the coordinates for baseline by subtracting Ascent metric of the font. There is slight improvement to be made. Currently we are not considering LineGap when we calculate the baseline (or we are keeping whole line gap below the font). After testing various cases with Word processing applications like Word and Libreoffice and WPF outputs and comparing them with PoDoFo output, I have observed that there is small discrepancy, which is especially significant for large fonts with large line gap values. The fix is to keep half linegap on top also. Current behavior : BaseLine= Top - Ascent Improved behaviour : BaseLine = Top - Ascent - LineGap/2 After this podofo matches very well with other application It is not possible for me to generate a unified diff against latest revision now I have attached the relevant function I have also attached a diff against revision 1767. This has both above mentioned fix, and improvement to GetMultiLineTextAsLines as function also (This was sent before also but not yet committed). Regards Ali ------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
