Hey there,
I was on vacation so i didnt read emails :-)
Regarding the patch:
Looks good, according to msdn this should work fine...
I dont really like the use of the Windows API and i am unable to test
this patch atm due to time limitations (can you believe it? I have to do
work at my workplace ;-) ).
The code looks fine, if Jaseem has tested it, it should be ok.
Why do i not like the Windows api approach?
First of all :
The pre-patch code did all kinds of locale checks, encoding checks etc.
this needs to be done if working with ttc/ttfs.
This seems to be all hidden in the windows api call... if this code does
not work the way we want it to work it will be very hard to find the
actually error...
Second:
I dont trust Micro$ofts Apis. They are janky and have all sorts of traps
in them...
What i would like to see is:
This Patch on a Japanese System with Russian Languange pack installed
asking for Meiryo. If Podofo handles this case it should be good for
every case...
(Doesnt have to be japanese and russian, but it should be 2 different
languages which both have a non latin alphabet)
BUT, that said:
The api approach is less codelines and you need almost no knowledge
about the ttc/ttf format to understand the code so thats a big plus!
Greetings,
Dennis
--
dots <http://www.dots.de/en/>
Dennis Voss
dots Software GmbH
Schlesische Str. 27, 10997 Berlin, Germany
Tel: +49 (0)30 695 799-47
Fax: +49 (0)30 695 799-55
dennis.v...@dots.de <mailto:dennis.v...@dots.de>
http://www.dots.de <http://www.dots.de/>
Amtsgericht Berlin Charlottenburg HRB 65201
Geschäftsführer: Olaf Lorenz
Follow us on: Twitter <http://www.dots.de/?id=twitter> Youtube
<http://www.dots.de/?id=youtube> Xing <http://www.dots.de/?id=xing>
------------------------------------------------------------------------------
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
