On Mon, 2017-01-16 at 17:14 +0000, Mark Rogers wrote:
> Here’s a final patch for this release
Hi,
thanks for the patch. The gcc had been unhappy about this change:
In file included from .../podofo/trunk/src/base/PdfEncrypt.h:39:0,
from .../podofo/trunk/src/base/PdfString.cpp:36:
.../podofo/trunk/src/base/PdfReference.h: In constructor
‘PoDoFo::PdfReference::PdfReference()’:
.../podofo/trunk/src/base/PdfReference.h:175:19: warning:
‘PoDoFo::PdfReference::m_nObjectNo’ will be initialized after [-Wreorder]
pdf_objnum m_nObjectNo;
^~~~~~~~~~~
.../podofo/trunk/src/base/PdfReference.h:174:19: warning:
‘PoDoFo::pdf_gennum PoDoFo::PdfReference::m_nGenerationNo’ [-Wreorder]
pdf_gennum m_nGenerationNo;
^~~~~~~~~~~~~~~
.../podofo/trunk/src/base/PdfReference.h:67:5: warning: when initialized
here [-Wreorder]
PdfReference()
^~~~~~~~~~~~
.../podofo/trunk/src/base/PdfReference.h: In constructor
‘PoDoFo::PdfReference::PdfReference(PoDoFo::pdf_objnum, PoDoFo::pdf_gennum)’:
.../podofo/trunk/src/base/PdfReference.h:175:19: warning:
‘PoDoFo::PdfReference::m_nObjectNo’ will be initialized after [-Wreorder]
pdf_objnum m_nObjectNo;
^~~~~~~~~~~
.../podofo/trunk/src/base/PdfReference.h:174:19: warning:
‘PoDoFo::pdf_gennum PoDoFo::PdfReference::m_nGenerationNo’ [-Wreorder]
pdf_gennum m_nGenerationNo;
^~~~~~~~~~~~~~~
.../podofo/trunk/src/base/PdfReference.h:78:5: warning: when initialized
here [-Wreorder]
PdfReference( const pdf_objnum nObjectNo, const pdf_gennum
nGenerationNo )
^~~~~~~~~~~~
but I fixed it before committing, as revision 1811:
http://sourceforge.net/p/podofo/code/1811
> BTW There’s still a lot of wasted space inside PdfObject - about 28%
> of the space allocated for PdfObject is alignment padding on 32-bit
> platforms. Eliminating this will reduce memory requirements by 28%,
> but requires bigger changes than just re-ordering members. I’ll look
> at that for next release.
That sounds pretty interesting.
Thanks and bye,
zyx
--
http://www.litePDF.cz [email protected]
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Podofo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/podofo-users
