Hi

There‘s a problem in release builds. PdfPainter::~PdfPainter throws exceptions 
in release builds because PODOFO_ASSERT throws exceptions via 
PODOFO_RAISE_ERROR_INFO in release builds

PdfPainter::~PdfPainter()
{
                // Throwing exceptions in C++ destructors is not allowed.
                // Just log the error.
    // PODOFO_RAISE_LOGIC_IF( m_pCanvas, "FinishPage() has to be called after a 
page is completed!" );
    // Note that we can't do this for the user, since FinishPage() might
    // throw and we can't safely have that in a dtor. That also means
    // we can't throw here, but must abort.
    if( m_pCanvas )
        PdfError::LogMessage( eLogSeverity_Error,
                              "PdfPainter::~PdfPainter(): FinishPage() has to 
be called after a page is completed!" );

    PODOFO_ASSERT( !m_pCanvas );
}

Simplest fix is deleting the assert or putting an #ifdef DEBUG round it:

#ifdef DEBUG
    PODOFO_ASSERT( !m_pCanvas );
#endif

Best Regards
Mark


Mark Rogers - mark.rog...@powermapper.com
PowerMapper Software Ltd - www.powermapper.com
Registered in Scotland No 362274 Quartermile 2 Edinburgh EH3 9GL






From: Dominik Seichter <domseich...@googlemail.com>
Date: Thursday, 19 January 2017 at 20:10
To: Mark Rogers <mark.rog...@powermapper.com>
Cc: zyx <z...@litepdf.cz>, "podofo-users@lists.sourceforge.net" 
<podofo-users@lists.sourceforge.net>
Subject: Re: [Podofo-users] PoDoFo 0.9.5.-rc1 Read for Download

Hi Mark,

Thanks for the patch. As it is only a minor change for a test I applied it now.
Committed to revision 1816.

Best regards,
 Dominik

On Thu, Jan 19, 2017 at 6:40 PM, Mark Rogers 
<mark.rog...@powermapper.com<mailto:mark.rog...@powermapper.com>> wrote:
Hi

I built and tested for 0.9.5-rc1 for Windows 32 bit and Mac 64 bit. No problems 
so far.

I did see one warning about a type conversion in one of the unit tests 
(pdf_long return value stored in an int). I’ve attached a patch to fix it, but 
this can wait till after the release.

Cheers
Mark


Mark Rogers - mark.rog...@powermapper.com<mailto:mark.rog...@powermapper.com>
PowerMapper Software Ltd - www.powermapper.com<http://www.powermapper.com>
Registered in Scotland No 362274 Quartermile 2 Edinburgh EH3 9GL



On 17/01/2017, 08:17, "zyx" <z...@litepdf.cz> wrote:

    On Mon, 2017-01-16 at 20:25 +0100, Dominik Seichter wrote:
    > Please report any issues you have with this release candidate.

        Hi,
    there's one pending change, from Jaseem Ali, "Multiline Text Bug",
    which should surely be included in the final 0.9.5, I only hope that
    Jaseem will be able to provide the patch as soon as possible.
        Bye,
        zyx

    --
    http://www.litePDF.cz                                 i...@litepdf.cz

    
------------------------------------------------------------------------------
    Check out the vibrant tech community on one of the world's most
    engaging tech sites, SlashDot.org! http://sdm.link/slashdot
    _______________________________________________
    Podofo-users mailing list
    
Podofo-users@lists.sourceforge.net<mailto:Podofo-users@lists.sourceforge.net>
    https://lists.sourceforge.net/lists/listinfo/podofo-users


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net<mailto:Podofo-users@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/podofo-users

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to